Don't destroy replicas part of shutdown nexuses #862
Merged
+332
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Sep 16, 2024
tiagolobocastro
commented
In case nexus shutdown failed we used to disown the replica from both the volume and the nexus. This can be a problem if the nexus is still running as the io-engine does not handle it gracefully, leading into pool lock issues. Instead, simply disown the replica from the volume and not the nexus. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
This was referenced Sep 16, 2024
When nexus shutdown fails, if the node comes back online let's attempt the shutdown again. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
replica-disown
branch
from
861e87b
to
00c3fdc
Compare
dsharma-dc
approved these changes
Sep 18, 2024
control-plane/agents/src/bin/core/controller/reconciler/volume/garbage_collector.rs
Show resolved
Hide resolved
control-plane/agents/src/bin/core/controller/reconciler/volume/garbage_collector.rs
Show resolved
Hide resolved
Abhinandan-Purkait
approved these changes
Sep 18, 2024
control-plane/agents/src/bin/core/controller/reconciler/nexus/re_shutdown.rs
Show resolved
Hide resolved
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.