feat: handle new nvmf uri scheme #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
tiagolobocastro,
Abhinandan-Purkait,
sinhaashish and
abhilashshetty04
and removed request for
tiagolobocastro
|
bors try |
tryTimed out. |
|
bors cancel |
tryBuild succeeded: |
Abhinandan-Purkait
approved these changes
Sep 11, 2024
dsharma-dc
force-pushed
the
nvmf_uri
branch
4 times, most recently
from
abe3eb4
to
1f79514
Compare
dsharma-dc
force-pushed
the
nvmf_uri
branch
2 times, most recently
from
e9dfd43
to
0227cb5
Compare
|
bors try |
tryBuild succeeded: |
dsharma-dc
force-pushed
the
nvmf_uri
branch
from
0227cb5
to
53a3219
Compare
sinhaashish
approved these changes
Sep 16, 2024
tiagolobocastro
approved these changes
Sep 16, 2024
This shouldn't change the current behaviour w.r.t finding existing path. Further changes will make use of this to decide path removal criteria. The rdma apable uri comes in with scheme "nvmf+rdma+tcp", where we only take out rdma from the scheme to use as transport. When the csi-node behaviour is modified to attempt tcp connect in case initiator is not rdma capable, then the second transport i.e. tcp will be checked from uri scheme. Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
force-pushed
the
nvmf_uri
branch
from
53a3219
to
467d04c
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets the control plane csi node plugin to consume the new scheme deviceUri received from volume publish response during the volume attach path. For HA, things should work fundamentally with this. Some additional HA handling will be part of next patch where we handle HA path replacement with transport specific matching.