-
Notifications
You must be signed in to change notification settings - Fork 106
Add podAntiAffinity option to lvm-controller #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@SupeReuven Please sign your commit. |
deploy/helm/charts/values.yaml
Outdated
| # accounting for rolled over qps from previous seconds. | ||
| burst: 0 | ||
| podAntiAffinity: | ||
| enable: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are doing this, make this configurable as well. i.e take the values from helm values as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhinandan-Purkait do you meant this change deploy/helm/charts/README.md ?
Abhinandan-Purkait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, otherwise. Thanks!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #423 +/- ##
===========================================
- Coverage 98.66% 98.46% -0.20%
===========================================
Files 2 2
Lines 673 979 +306
===========================================
+ Hits 664 964 +300
- Misses 5 8 +3
- Partials 4 7 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Reuven Aharoni <[email protected]>
85b3ba1 to
f854cc3
Compare
Signed-off-by: Reuven Aharoni <[email protected]>
b6f5cda to
0aba431
Compare
Signed-off-by: Reuven Aharoni <[email protected]>
0392573 to
354d020
Compare
This issue is part of #420
that it require to have podAntiAffinity at lvm-controller
This PR have trigger to disable and enable the podAntiAffinity