Skip to content

Conversation

@SupeReuven
Copy link

This issue is part of #420
that it require to have podAntiAffinity at lvm-controller

This PR have trigger to disable and enable the podAntiAffinity

@SupeReuven SupeReuven requested a review from a team as a code owner November 10, 2025 08:36
@Abhinandan-Purkait
Copy link
Member

@SupeReuven Please sign your commit.

- In your local branch, run: git rebase HEAD~1 --signoff
- Force push your changes to overwrite the branch: git push --force-with-lease origin podAntiAffinity

# accounting for rolled over qps from previous seconds.
burst: 0
podAntiAffinity:
enable: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are doing this, make this configurable as well. i.e take the values from helm values as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhinandan-Purkait do you meant this change deploy/helm/charts/README.md ?

Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise. Thanks!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (8feeaa0) to head (85b3ba1).
⚠️ Report is 153 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #423      +/-   ##
===========================================
- Coverage    98.66%   98.46%   -0.20%     
===========================================
  Files            2        2              
  Lines          673      979     +306     
===========================================
+ Hits           664      964     +300     
- Misses           5        8       +3     
- Partials         4        7       +3     
Flag Coverage Δ
bddtests 98.46% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Reuven Aharoni <[email protected]>
@SupeReuven SupeReuven force-pushed the podAntiAffinity branch 2 times, most recently from b6f5cda to 0aba431 Compare November 18, 2025 16:05
Signed-off-by: Reuven Aharoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants