Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chores): Fix gocov-html package #354

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

mhkarimi1383
Copy link
Contributor

@mhkarimi1383 mhkarimi1383 commented Dec 14, 2024

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

not able to install gocov-html

due to

  go: gopkg.in/matm/v1/gocov-html@latest: unrecognized import path "gopkg.in": parse https://gopkg.in/?go-get=1: no go-import meta tags ()

What this PR does?: Fixes package name in Makefile to fix make bootstrap

Does this PR require any upgrade changes?: No

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: Muhammed Hussein Karimi <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (8feeaa0) to head (d98e3f1).
Report is 39 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #354      +/-   ##
===========================================
- Coverage    98.66%   97.22%   -1.44%     
===========================================
  Files            2        2              
  Lines          673      902     +229     
===========================================
+ Hits           664      877     +213     
- Misses           5       18      +13     
- Partials         4        7       +3     
Flag Coverage Δ
bddtests 97.22% <ø> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsharma-dc dsharma-dc merged commit ee6bad2 into openebs:develop Dec 16, 2024
5 checks passed
@mhkarimi1383 mhkarimi1383 deleted the fix-gocov-html-package branch December 16, 2024 11:13
@dsharma-dc
Copy link
Contributor

hmm looks like the build and push action is failing recently. The Ubuntu version seems to be used now is noble 24.04. It used to be jammy 22.04 till now. Need to see what's causing http 404 now during minikube setup.

@dsharma-dc
Copy link
Contributor

hmm looks like the build and push action is failing recently. The Ubuntu version seems to be used now is noble 24.04. It used to be jammy 22.04 till now. Need to see what's causing http 404 now during minikube setup.

Related issue:
medyagh/setup-minikube#565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants