feat(provisioning): extra format options (mkfs) added
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
…ction I had to upgrade some packages and switched to newer mount utils (currently used lib is depricated) Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
mhkarimi1383
force-pushed
the
feat-mkfs-options
branch
from
e931f2c
to
de805a6
Compare
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
mhkarimi1383
force-pushed
the
feat-mkfs-options
branch
from
6a46aef
to
6fc3b35
Compare
Signed-off-by: Muhammed Hussein Karimi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
adding extra format (
mkfs) options to newly created Volumesalso switched from deprecated
utils/monuttomount-utilsto be able to add this feature and moving from an old package to a maintained oneWhat this PR does?:
Refactor to new mount utils package and change format and mount function
Does this PR require any upgrade changes?:
No, But requires document updates for StorageClasses
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>