Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new CI colors #979

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use new CI colors #979

wants to merge 3 commits into from

Conversation

serverhorror
Copy link
Contributor

fix #978

Description here ...

Closes #...
Fixes #...

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@serverhorror serverhorror marked this pull request as draft December 15, 2023 16:36
@serverhorror serverhorror marked this pull request as ready for review December 15, 2023 17:23
@serverhorror
Copy link
Contributor Author

@sklingel does this look OK to you?

@sklingel
Copy link
Contributor

sklingel commented Jan 8, 2024

I would suggest to also change than the default colors / palette of the example plots, otherwise it will be very weird.

https://github.com/serverhorror/ods-quickstarters/blob/feature/978-ds-streamlit-uses-old-ci-colors/ds-streamlit/files/src/plots/config.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklingel sklingel Awaiting requested review from sklingel sklingel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ds-streamlit uses old CI colors
2 participants
@serverhorror @sklingel