Docker plain helm chart #1035
Open
Docker plain helm chart #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t name and release name
…on helm notes and remove switch cases on k8s version on ingress template
gerardcl
requested review from
serverhorror,
oalyman,
kuebler,
metmajer,
henrjk,
jorge-romero,
jafarre-bi,
tbugfinder and
renedupont
and removed request for
michaelsauter
gerardcl
force-pushed
the
docker-plain-helm-chart
branch
from
0c59afc
to
8b87c2c
Compare
…hart usage out of Jenkins CICD pipeline context
BraisVQ
force-pushed
the
docker-plain-helm-chart
branch
from
0c9c4dd
to
6148c67
Compare
|
The base image has been changed to |
and this also now does match with the values.yaml image section, perfect! |
|
Provision, build, and release pipelines have been tested and works out of the box with the latest commits. |
BraisVQ
reviewed
Sep 9, 2024
| @@ -0,0 +1,41 @@ | |||
| # TODO | |||
There was a problem hiding this comment.
Just in case we forget, this file should be removed before the PR is merged
segfault16
commented
Sep 17, 2024
segfault16
commented
Sep 17, 2024
segfault16
commented
Sep 17, 2024
| - Review helm install command | ||
| - Release manager image checks | ||
| - Agree if helm install requires overwritting values on image (see helm notes and deployment, and values.yaml) | ||
| - provide docs on how to test chart updates, by running `helm --debug template . ` under the chart folder to be tested |
segfault16
commented
Sep 17, 2024
BraisVQ
reviewed
Sep 17, 2024
PullPolicy: Always will not work when testing locally
segfault16
commented
Sep 17, 2024
| kind load docker-image testing/my-component:$(git rev-parse --short=8 HEAD) | ||
| helm upgrade --install --wait --atomic --namespace docker-plain --set image.path=testing --set image.name=my-component --set image.tag=$(git rev-parse --short=8 HEAD) docker-plain chart | ||
| ``` | ||
|
|
||
| ## How to create a custom jenkins-agent out of this docker-plain component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helm chart for docker plain
Refers to #1013
Tasks:
docs/modules/...directory<quickstarter>/testdatadirectory