Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for start and finish task also with private cert #734

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented Oct 12, 2023

Before #722, it was possible to run all tests using a private cert, by supplying -private-cert to go test. The downside of this was that all tests on GitHub ran without it, to avoid overly long test times. Now that the overall test time is way shorter, we can afford to add one test for each task to run with private cert enabled.

Tasks:

  • Updated design documents in docs/design directory or not applicable
  • Updated user-facing documentation in docs directory or not applicable
  • Ran tests (e.g. make test) or not applicable
  • Updated changelog or not applicable

@michaelsauter michaelsauter self-assigned this Oct 12, 2023
@michaelsauter michaelsauter merged commit bf4936c into master Oct 12, 2023
3 of 4 checks passed
@michaelsauter michaelsauter deleted the task/add-tests-with-private-cert branch October 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant