Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(ray): new path to manifests #640

Merged
merged 1 commit into from
Oct 20, 2023
Merged

update(ray): new path to manifests #640

merged 1 commit into from
Oct 20, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 18, 2023 •
edited
Loading

Description

part of : #600

How Has This Been Tested?

local build quay.io/wenzhou/opendatahub-operator-catalog:v2.10.600-99

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from etirelli and LaVLaS October 18, 2023 10:31
@zdtsw zdtsw requested review from VaishnaviHire and removed request for LaVLaS October 18, 2023 10:53
@VanillaSpoon
Copy link

Tested these changes, and works as expected. Thanks so much @zdtsw lgtm :)

@zdtsw
Copy link
Member Author

zdtsw commented Oct 18, 2023

/test opendatahub-operator-e2e

@dimakis dimakis mentioned this pull request Oct 18, 2023
Open
20 tasks
@zdtsw zdtsw added the odh-1.11 label Oct 18, 2023
VaishnaviHire
VaishnaviHire approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes. Works as expected

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 70689b1 into opendatahub-io:incubation Oct 20, 2023
2 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Oct 20, 2023
@zdtsw @VaishnaviHire
update(ray): new path to manifests (opendatahub-io#640)
9010b47 
Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 70689b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@etirelli etirelli Awaiting requested review from etirelli

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved lgtm odh-1.11 rhods-2.4
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @VanillaSpoon @VaishnaviHire