-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codeflare): support unmanaged #604
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d61a87e
to
c42b985
Compare
/test all |
/test opendatahub-operator-e2e |
/test all |
When I uninstall the existing codeflare operator, and the state is set to
|
Should we include the changes for |
i was talking to DW team yesterday, as they are still using |
good idea! |
- set default to CFO unmanaged + Ray managed than previous removed - Add e2e test and add component name into message - update e2e test log - update(codeflare): flip logic after find CFO already installed Signed-off-by: Wen Zhou <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@zdtsw Are these changes still needed? |
close it since we have changed the way to deploy codeflare |
Description
for the scope fo 1.35/2.4, since CFO will be on TP, we can keep the same logic of ODH operator
and add more to handle "unmanaged" if it is needed in 2.5
ref: #600
depend on #652
How Has This Been Tested?
new test
wait for rebase after #652 to update
old test
when set "codeflare" to Unmanaged, when others are either Managed or Removed
it does not block codeflare(no reconcile on missing CFO):
and it applied codeflare's manifests
and created imagestream
Merge criteria: