Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: e2e: increase timeout to 40m #1596

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

ykaliuta
Copy link
Contributor

Components tests after refactoring is performed sequentially and due to dependencies it's tricky to run them in parallel.

Workaround: increase timeout to unblock CI queue.

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Components tests after refactoring is performed sequentially and due
to dependencies it's tricky to run them in parallel.

Workaround: increase timeout to unblock CI queue.

Signed-off-by: Yauheni Kaliuta <[email protected]>
Copy link

openshift-ci bot commented Jan 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ykaliuta
Copy link
Contributor Author

/test all

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.94%. Comparing base (cb2baa9) to head (a575029).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   19.94%   19.94%           
=======================================
  Files         158      158           
  Lines       10799    10799           
=======================================
  Hits         2154     2154           
  Misses       8415     8415           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykaliuta ykaliuta marked this pull request as ready for review January 30, 2025 13:08
@ykaliuta
Copy link
Contributor Author

/cc @zdtsw @lburgazzoli

@openshift-ci openshift-ci bot requested review from lburgazzoli and zdtsw January 30, 2025 13:32
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8340068 into opendatahub-io:main Jan 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants