-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: remove Authorino patch for ossm #1513
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 19.84% 19.95% +0.10%
==========================================
Files 159 159
Lines 10794 10790 -4
==========================================
+ Hits 2142 2153 +11
+ Misses 8424 8409 -15
Partials 228 228 ☔ View full report in Codecov by Sentry. |
You might want to handle the upgrade path as well - cleaning up the orphaned |
- no need to patch servicemesh sidecar into Authorino deployment - add label directly on Authorino CR should auto pass to its pod Signed-off-by: Wen Zhou <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
@zdtsw it appears the Authorino team is not planning to propagate labels from the Authoriono CR as originally proposed by @bartoszmajsak - I asked for confirmation in Kuadrant/authorino-operator#243 |
thanks for the info. |
close this in favor of #1702 after changes proposed in Kuadrant/authorino-operator#243 |
this PR is depending on new Authorino release which must have Kuadrant/authorino-operator#236 || Kuadrant/authorino-operator#243 or similar fix includeded first.
Description
related to jira: https://issues.redhat.com/browse/RHOAIENG-18238
How Has This Been Tested?
Screenshot or short clip
Merge criteria