Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: remove Authorino patch for ossm #1513

Closed
wants to merge 2 commits into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 17, 2025

this PR is depending on new Authorino release which must have Kuadrant/authorino-operator#236 || Kuadrant/authorino-operator#243 or similar fix includeded first.

  • no need to patch servicemesh sidecar into Authorino deployment
  • add label directly on Authorino CR should auto pass to its pod

Description

related to jira: https://issues.redhat.com/browse/RHOAIENG-18238

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw changed the title update: remove Authorino patch we did in the past update: remove Authorino patch for ossm Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 19.95%. Comparing base (eb42450) to head (7f56114).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
pkg/upgrade/upgrade.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   19.84%   19.95%   +0.10%     
==========================================
  Files         159      159              
  Lines       10794    10790       -4     
==========================================
+ Hits         2142     2153      +11     
+ Misses       8424     8409      -15     
  Partials      228      228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartoszmajsak
Copy link
Contributor

You might want to handle the upgrade path as well - cleaning up the orphaned FeatureTracker

zdtsw added 2 commits January 27, 2025 09:11
- no need to patch servicemesh sidecar into Authorino deployment
- add label directly on Authorino CR should auto pass to its pod

Signed-off-by: Wen Zhou <[email protected]>
@lphiri
Copy link

lphiri commented Feb 26, 2025

@zdtsw it appears the Authorino team is not planning to propagate labels from the Authoriono CR as originally proposed by @bartoszmajsak - I asked for confirmation in Kuadrant/authorino-operator#243
It appears for now we will need to keep patching, but should move the injection from annotation to label.

@zdtsw
Copy link
Member Author

zdtsw commented Feb 27, 2025

@zdtsw it appears the Authorino team is not planning to propagate labels from the Authoriono CR as originally proposed by @bartoszmajsak - I asked for confirmation in Kuadrant/authorino-operator#243 It appears for now we will need to keep patching, but should move the injection from annotation to label.

thanks for the info.
i update this draft accordingly

@zdtsw
Copy link
Member Author

zdtsw commented Feb 27, 2025

close this in favor of #1702 after changes proposed in Kuadrant/authorino-operator#243

@zdtsw zdtsw closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants