Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jupyter / Anaconda resource links #3562

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Dec 10, 2024

https://issues.redhat.com/browse/RHOAIENG-10874

Description

Before:

Scikit-learn Screenshot 2024-12-10 at 2 14 39 PM Screenshot 2024-12-09 at 5 04 18 PM
Anaconda for Data Science Screenshot 2024-12-10 at 1 59 26 PM Screenshot 2024-12-10 at 2 19 51 PM

After:

Scikit-learn Screenshot 2024-12-10 at 2 08 00 PM Screenshot 2024-12-09 at 5 21 03 PM
Anaconda for data science Screenshot 2024-12-10 at 1 59 26 PM Screenshot 2024-12-10 at 2 11 09 PM

How Has This Been Tested?

  1. In Openshift Console, open YAML editor, select opendatahub as project, and copy/paste https://github.com/opendatahub-io/odh-dashboard/blob/0ba281c70ee6dbb02b55a420db82691e37485221/manifests/rhoai/shared/apps/anaconda-ce/anaconda-ce-app.yaml
  2. In Openshift Console, open YAML editor, select opendatahub as project, and copy/paste the updated anaconda-ce-docs.yaml from this PR.
  3. Verify the links in the resource cards shown above work as expected.

Test Impact

N/A, changes to YAML only.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jenny-s51 jenny-s51 changed the title RHOAIENG-10874: Update Jupyter resource links Update Jupyter / Anaconda resource links Dec 10, 2024
@jenny-s51 jenny-s51 requested review from ashley-o0o and removed request for manaswinidas and dpanshug December 10, 2024 19:33
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (70e0d4e) to head (a11ec92).
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3562      +/-   ##
==========================================
- Coverage   85.56%   85.51%   -0.05%     
==========================================
  Files        1372     1378       +6     
  Lines       31211    31244      +33     
  Branches     8741     8738       -3     
==========================================
+ Hits        26705    26718      +13     
- Misses       4506     4526      +20     

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e0d4e...a11ec92. Read the comment docs.

@ashley-o0o
Copy link
Contributor

ashley-o0o commented Dec 11, 2024

Tested the new YAML, broken links are now working as they should
/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1896f34 into opendatahub-io:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants