-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multiple models deploy #3561
Fixing multiple models deploy #3561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick fix for the test here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested on kserve-pm (modelmesh and kserve) and on ai-dev04.kni.syseng
(borrowed from the NIM team) for the NIM form changes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI @jeff-phillips-18 , fixing some more InferenceService name stuff here that was caused by #3464. Sorry I overlooked these when talking through that PR with you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3561 +/- ##
==========================================
- Coverage 85.56% 85.40% -0.16%
==========================================
Files 1372 1378 +6
Lines 31211 31428 +217
Branches 8741 8797 +56
==========================================
+ Hits 26705 26842 +137
- Misses 4506 4586 +80
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* fixing multiple models deploy * test update * fix tests * additional test
* fixing multiple models deploy * test update * fix tests * additional test
Closing issue 2 from https://issues.redhat.com/browse/RHOAIENG-16540
Description
When selecting multiple models on a multi model server it was throwing and error when trying to deploy a second model. Found on kserve cluster.
Before
After
How Has This Been Tested?
2 Scenarios
Test Impact
Fixed the failing test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main