Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple models deploy #3561

Merged

Conversation

YuliaKrimerman
Copy link
Contributor

@YuliaKrimerman YuliaKrimerman commented Dec 10, 2024

Closing issue 2 from https://issues.redhat.com/browse/RHOAIENG-16540

Description

When selecting multiple models on a multi model server it was throwing and error when trying to deploy a second model. Found on kserve cluster.
Before
image
After
Screenshot 2024-12-10 at 2 11 07 PM

How Has This Been Tested?

2 Scenarios

  1. Any cluster - In Data Science projects go to models, choose Multi-model serving platform. Add a model server.Deploy a model. Try to deploy a 2nd mode. Make sure that no error appears.
  2. Cluster that has NIM enabled- we need to make sure that the InferenceService gets the right name when deploying a kserve model or a NIM model.

Test Impact

Fixed the failing test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick fix for the test here

frontend/src/api/k8s/__tests__/inferenceServices.spec.ts Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Dec 11, 2024
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on kserve-pm (modelmesh and kserve) and on ai-dev04.kni.syseng (borrowed from the NIM team) for the NIM form changes.

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2024
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor

mturley commented Dec 11, 2024

FYI @jeff-phillips-18 , fixing some more InferenceService name stuff here that was caused by #3464. Sorry I overlooked these when talking through that PR with you.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (70e0d4e) to head (fd0e462).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3561      +/-   ##
==========================================
- Coverage   85.56%   85.40%   -0.16%     
==========================================
  Files        1372     1378       +6     
  Lines       31211    31428     +217     
  Branches     8741     8797      +56     
==========================================
+ Hits        26705    26842     +137     
- Misses       4506     4586      +80     
Files with missing lines Coverage Δ
frontend/src/api/k8s/inferenceServices.ts 96.66% <100.00%> (ø)
...projects/NIMServiceModal/ManageNIMServingModal.tsx 87.21% <100.00%> (ø)
.../NIMServiceModal/NIMModelDeploymentNameSection.tsx 100.00% <100.00%> (ø)

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e0d4e...fd0e462. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 9124c70 into opendatahub-io:main Dec 11, 2024
6 checks passed
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
* fixing multiple models deploy

* test update

* fix tests

* additional test
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
* fixing multiple models deploy

* test update

* fix tests

* additional test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants