ValidateISV Endpoint Update

[ashley-o0o]

Closes: RHOAIENG-16251

Description

Quick update for the ValidateISV Endpoint. Also add logic to hide the enable button if the user isn't an admin.

How Has This Been Tested?

npm run test and locally

Test Impact

No changes

Screenshots

Admin:

Non admin:

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[christianvogt]

Testing using curl to endpoint /api/validate-isv/results
Now requires admin access.

Also tested by applying the anaconda app. The user now will see this error:

@andrewballantyne is this expected because the UI is available to non-admins at this time. Should the UI be hidden or partially disabled to all but odh admins?

[andrewballantyne]

@christianvogt it doesn't make sense for non-admins to use this flow... perhaps hiding the Enable button if you're not isAdmin would be helpful too. Good catch.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (e4bac88) to head (aafab34).
Report is 31 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3541      +/-   ##
==========================================
- Coverage   85.56%   85.17%   -0.40%     
==========================================
  Files        1342     1380      +38     
  Lines       31016    31542     +526     
  Branches     8675     8818     +143     
==========================================
+ Hits        26538    26865     +327     
- Misses       4478     4677     +199     

Files with missing lines	Coverage Δ
...d/src/pages/exploreApplication/GetStartedPanel.tsx	64.28% <100.00%> (+1.32%)	⬆️

... and 362 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4bac88...aafab34. Read the comment docs.

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment