fix adding dropdown fields to section

[christianvogt]

Description

Fixes validation with connection type dropdown items. Labels are not required and therefore empty labels should not cause the form to become invalid.

Fixes adding fields to sections.

How Has This Been Tested?

• enable the connection type feature flag
• create a new connection type
• add a section
• click the add field button for the section
• select the field type as drop down
• add a name and env var
• add an item and supply value v1
• add another item and supply value v2
• Ensure the modal can be saved
• save the modal
• observe the item is correctly added to the section
• try adding another field to the same or another section

Test Impact

added test case

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @simrandhaliw

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.63%. Comparing base (7023236) to head (f19e0d1).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
...onTypes/manage/ManageConnectionTypeFieldsTable.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3448   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files        1346     1346           
  Lines       30586    30590    +4     
  Branches     8496     8498    +2     
=======================================
+ Hits        26191    26196    +5     
+ Misses       4395     4394    -1     

Files with missing lines	Coverage Δ
...manage/advanced/DropdownAdvancedPropertiesForm.tsx	89.55% <100.00%> (+0.66%)	⬆️
...onTypes/manage/ManageConnectionTypeFieldsTable.tsx	48.33% <0.00%> (ø)

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7023236...f19e0d1. Read the comment docs.

[emilys314]

looks good! I tested the empty labels on the dropdown and the adding of a field to a section

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment