-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(12782): display actual error msg for failed mr creation #3444
fix(12782): display actual error msg for failed mr creation #3444
Conversation
Signed-off-by: gitdallas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
- Coverage 85.95% 85.58% -0.37%
==========================================
Files 1339 1344 +5
Lines 30357 30551 +194
Branches 8388 8470 +82
==========================================
+ Hits 26093 26147 +54
- Misses 4264 4404 +140 see 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gitdallas
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-12782
Description
give the real error message from k8s, this includes "[name] already exists"
How Has This Been Tested?
locally, kserve cluster, creating an MR (in MR settings) that has the same name as an existing MR. Run backend and frontend separately to see the changes in this PR.
Test Impact
none
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main