Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(12782): display actual error msg for failed mr creation #3444

Conversation

gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Nov 6, 2024

closes: https://issues.redhat.com/browse/RHOAIENG-12782

Description

give the real error message from k8s, this includes "[name] already exists"
image

How Has This Been Tested?

locally, kserve cluster, creating an MR (in MR settings) that has the same name as an existing MR. Run backend and frontend separately to see the changes in this PR.

Test Impact

none

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (537a427) to head (91c1e52).
Report is 38 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3444      +/-   ##
==========================================
- Coverage   85.95%   85.58%   -0.37%     
==========================================
  Files        1339     1344       +5     
  Lines       30357    30551     +194     
  Branches     8388     8470      +82     
==========================================
+ Hits        26093    26147      +54     
- Misses       4264     4404     +140     

see 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537a427...91c1e52. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Needed to run backend and frontend separately to see the changes in this PR... will update the PR description. [edit] updated the PR description "How has this been tested?" section.

Screenshot 2024-11-07 at 5 09 55 PM

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gitdallas

Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3658290 into opendatahub-io:main Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants