-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-1107] Storage Class Filter #3235
[RHOAIENG-1107] Storage Class Filter #3235
Conversation
Thanks @jpuzz0 . Overall, it looks good to me. |
e7e49c5
to
e78ef7f
Compare
@xianli123 thanks for pointing this out! This is now corrected: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3235 +/- ##
=======================================
Coverage ? 85.08%
=======================================
Files ? 1292
Lines ? 28814
Branches ? 7749
=======================================
Hits ? 24515
Misses ? 4299
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @jpuzz0. LGTM! |
https://issues.redhat.com/browse/RHOAIENG-1107
Description
Added filter toolbar and pagination to the storage classes table page. Users can filter by display name and/or Openshift class name.
Demo:
https://github.com/user-attachments/assets/6d86fe29-a3c8-46f1-badc-e459dce17123
(cc @xianli123)
How Has This Been Tested?
/storageClasses?devFeatureFlags=disableStorageClasses
Test Impact
Added catch-all filter cypress test for storage classes
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main