Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1107] Storage Class Filter #3235

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Sep 20, 2024

https://issues.redhat.com/browse/RHOAIENG-1107

Description

Added filter toolbar and pagination to the storage classes table page. Users can filter by display name and/or Openshift class name.

image image image

Demo:
https://github.com/user-attachments/assets/6d86fe29-a3c8-46f1-badc-e459dce17123

(cc @xianli123)

How Has This Been Tested?

  1. With the feature flag enabled, visit the storage class table's page; /storageClasses?devFeatureFlags=disableStorageClasses
  2. Verify pagination exists
  3. Verify the toolbar filter exists and matches the design
  4. Verify you can filter by both display name and openshift class name
  5. Verify empty state when filter yields no results and can reset filters via the action in that empty state ("Clear filters")

Test Impact

Added catch-all filter cypress test for storage classes

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@xianli123
Copy link

Thanks @jpuzz0 . Overall, it looks good to me.
One small change would be that the "S" of "OpenShift" in the placeholder should be a capital letter.
image

@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Sep 23, 2024

Thanks @jpuzz0 . Overall, it looks good to me. One small change would be that the "S" of "OpenShift" in the placeholder should be a capital letter.

@xianli123 thanks for pointing this out! This is now corrected:
image

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@83472f4). Learn more about missing BASE report.
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nd/src/pages/storageClasses/StorageClassesPage.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3235   +/-   ##
=======================================
  Coverage        ?   85.08%           
=======================================
  Files           ?     1292           
  Lines           ?    28814           
  Branches        ?     7749           
=======================================
  Hits            ?    24515           
  Misses          ?     4299           
  Partials        ?        0           
Files with missing lines Coverage Δ
...src/concepts/dashboard/DashboardEmptyTableView.tsx 100.00% <ø> (ø)
frontend/src/k8sTypes.ts 100.00% <100.00%> (ø)
...ratorProfiles/screens/list/AcceleratorProfiles.tsx 100.00% <ø> (ø)
...es/storageClasses/ResetCorruptConfigValueAlert.tsx 94.11% <100.00%> (ø)
...pages/storageClasses/StorageClassFilterToolbar.tsx 100.00% <100.00%> (ø)
...d/src/pages/storageClasses/StorageClassesTable.tsx 100.00% <100.00%> (ø)
...rc/pages/storageClasses/StorageClassesTableRow.tsx 100.00% <100.00%> (ø)
frontend/src/pages/storageClasses/constants.ts 87.50% <100.00%> (ø)
...nd/src/pages/storageClasses/StorageClassesPage.tsx 61.90% <66.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83472f4...37eb79f. Read the comment docs.

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well
/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a509cf4 into opendatahub-io:main Sep 23, 2024
8 checks passed
@xianli123
Copy link

Thanks @jpuzz0. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants