Skip to content

Commit

Permalink
Cypress - Stabilise e2e Tests (#3776)
Browse files Browse the repository at this point in the history
* Comitting Smoke tests passing multiple times

* Reverting DC change

* Merge conflict

* Linting fixes

* Quarantining Single Model Creation test due to a Product bug

---------

Co-authored-by: Noam Manos <[email protected]>
  • Loading branch information
antowaddle and manosnoam authored Feb 20, 2025
1 parent 7fc7f32 commit f96c030
Show file tree
Hide file tree
Showing 8 changed files with 25 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ let modelName: string;
let modelFilePath: string;
const awsBucket = 'BUCKET_1' as const;

describe('Verify Admin Single Model Creation and Validation using the UI', () => {
describe('[Product Bug RHOAIENG-20213] Verify Admin Single Model Creation and Validation using the UI', () => {
retryableBefore(() => {
Cypress.on('uncaught:exception', (err) => {
if (err.message.includes('Error: secrets "ds-pipeline-config" already exists')) {
Expand Down Expand Up @@ -63,7 +63,7 @@ describe('Verify Admin Single Model Creation and Validation using the UI', () =>

it(
'Verify that an Admin can Serve, Query a Single Model using both the UI and External links',
{ tags: ['@Smoke', '@SmokeSet3', '@ODS-2626', '@Dashboard', '@Modelserving'] },
{ tags: ['@Smoke', '@SmokeSet3', '@ODS-2626', '@Dashboard', '@Modelserving', '@Bug'] },
() => {
cy.log('Model Name:', modelName);
// Authentication and navigation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '~/__tests__/cypress/cypress/utils/oc_commands/baseCommands';
import { retryableBefore } from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Verify a Jupyter Notebook can be launched directly from the Data Science Project List View', () => {
describe('[Automation Bug RHOAIENG-20207] Verify a Jupyter Notebook can be launched directly from the Data Science Project List View', () => {
let testData: NotebookImageData;

retryableBefore(() => {
Expand All @@ -24,7 +24,7 @@ describe('Verify a Jupyter Notebook can be launched directly from the Data Scien

it(
'Verify User Can Access Jupyter Launcher From DS Project Page',
{ tags: ['@Smoke', '@SmokeSet1', '@ODS-1877', '@Dashboard'] },
{ tags: ['@Smoke', '@SmokeSet1', '@ODS-1877', '@Dashboard', '@Bug'] },
() => {
// Authentication and navigation
cy.step('Log into the application');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
wasSetupPerformed,
} from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Start, Stop, Launch and Delete a Workbench in RHOAI', () => {
describe('[Automation Bug RHOAIENG-20128] Start, Stop, Launch and Delete a Workbench in RHOAI', () => {
let controlSuiteTestNamespace: string;
let controlSuiteTestDescription: string;

Expand Down Expand Up @@ -52,7 +52,9 @@ describe('Start, Stop, Launch and Delete a Workbench in RHOAI', () => {

it(
'Starting, Stopping, Launching and Deleting a Workbench',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1818', '@ODS-1823', '@ODS-1975', '@Dashboard'] },
{
tags: ['@Sanity', '@SanitySet2', '@ODS-1818', '@ODS-1823', '@ODS-1975', '@Dashboard', '@Bug'],
},
() => {
const workbenchName = controlSuiteTestNamespace.replace('dsp-', '');

Expand Down Expand Up @@ -106,7 +108,9 @@ describe('Start, Stop, Launch and Delete a Workbench in RHOAI', () => {
);
it(
'Verify that a Workbench can be started and stopped using the Event log controls',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1818', '@ODS-1823', '@ODS-1975', '@Dashboard'] },
{
tags: ['@Sanity', '@SanitySet2', '@ODS-1818', '@ODS-1823', '@ODS-1975', '@Dashboard', '@Bug'],
},
() => {
const workbenchName = controlSuiteTestNamespace.replace('dsp-', 'secondwb-');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
wasSetupPerformed,
} from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Edit and Update a Workbench in RHOAI', () => {
describe('[Automation Bug RHOAIENG-20128] Edit and Update a Workbench in RHOAI', () => {
let editTestNamespace: string;
let editedTestNamespace: string;
let editedTestDescription: string;
Expand Down Expand Up @@ -53,7 +53,7 @@ describe('Edit and Update a Workbench in RHOAI', () => {

it(
'Editing Workbench Name and Description',
{ tags: ['@Sanity', '@SanitySet1', '@ODS-1931', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet1', '@ODS-1931', '@Dashboard', '@Bug'] },
() => {
const workbenchName = editTestNamespace.replace('dsp-', '');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
wasSetupPerformed,
} from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Workbenches - status tests', () => {
describe('[Automation Bug RHOAIENG-20128] Workbenches - status tests', () => {
let projectName: string;
let projectDescription: string;

Expand Down Expand Up @@ -49,7 +49,7 @@ describe('Workbenches - status tests', () => {

it(
'Verify user can access progress and event log - validate status and successful workbench creation',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1970', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1970', '@Dashboard', '@Bug'] },
() => {
const workbenchName = projectName.replace('dsp-', '');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
wasSetupPerformed,
} from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Workbenches - tolerations tests', () => {
describe('[Automation bug RHOAIENG-20099] Workbenches - tolerations tests', () => {
let testData: WBTolerationsTestData;
let projectName: string;
let projectDescription: string;
Expand Down Expand Up @@ -70,7 +70,7 @@ describe('Workbenches - tolerations tests', () => {

it(
'Validate pod tolerations are applied to a Workbench',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard', '@Bug'] },
() => {
// Authentication and navigation
cy.step('Log into the application');
Expand Down Expand Up @@ -130,7 +130,7 @@ describe('Workbenches - tolerations tests', () => {

it(
'Validate pod tolerations for a stopped workbench',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard', '@Bug'] },
() => {
// Authentication and navigation
cy.step('Log into the application');
Expand Down Expand Up @@ -163,7 +163,7 @@ describe('Workbenches - tolerations tests', () => {

it(
'Validate pod tolerations when a workbench is restarted with tolerations and tolerations are disabled',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard', '@Bug'] },
() => {
// Authentication and navigation
cy.step('Log into the application');
Expand Down Expand Up @@ -201,7 +201,7 @@ describe('Workbenches - tolerations tests', () => {

it(
'Verifies that a new toleration is added to a new workbench but not to an already running workbench',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1969', '@ODS-2057', '@Dashboard', '@Bug'] },
() => {
// Set Pod Tolerations
cy.step('Navigate to Cluster Settings, save and set pod tolerations');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
wasSetupPerformed,
} from '~/__tests__/cypress/cypress/utils/retryableHooks';

describe('Workbenches - variable tests', () => {
describe('[Automation Bug RHOAIENG-20128] Workbenches - variable tests', () => {
let projectName: string;
let projectDescription: string;
let testData: WBVariablesTestData;
Expand All @@ -34,7 +34,7 @@ describe('Workbenches - variable tests', () => {
cy.log(`Project ${projectName} confirmed to be created and verified successfully`);
});
});
afterEach(() => {
after(() => {
//Check if the Before Method was executed to perform the setup
if (!wasSetupPerformed()) return;

Expand All @@ -46,7 +46,7 @@ describe('Workbenches - variable tests', () => {
});
it(
'Verify user can set environment variables in their workbenches by uploading a yaml Secret and Config Map file.',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1883', '@ODS-1864', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1883', '@ODS-1864', '@Dashboard', '@Bug'] },
() => {
const workbenchName = projectName;
const workbenchName2 = projectName.replace('dsp-', 'secondwb-');
Expand Down Expand Up @@ -122,7 +122,7 @@ describe('Workbenches - variable tests', () => {
);
it(
'Verify that the user can inject environment variables manually into a workbench using Key / Value',
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1883', '@ODS-1864', '@Dashboard'] },
{ tags: ['@Sanity', '@SanitySet2', '@ODS-1883', '@ODS-1864', '@Dashboard', '@Bug'] },
() => {
const workbenchName = projectName;
const workbenchName2 = projectName.replace('dsp-', 'secondwb-');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ describe('Regular Users can make use of the Storage Classes in the Cluster Stora
// Open the Create cluster storage Modal
findAddClusterStorageButton().click();

cy.step(
'Checking that Storage Classes Dropdown is disabled - 🐛 RHOAIENG-16609 will fail this test in RHOAI',
);
cy.step('Checking that Storage Classes Dropdown is disabled');
// Check that the SC Dropdown is disabled
addClusterStorageModal.findStorageClassSelect().should('be.disabled');
});
Expand Down

0 comments on commit f96c030

Please sign in to comment.