Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024a] RHOAIENG-16520, RHOAIENG-11807, RHOAIENG-16955: update setuptools to 70.0.0 for CVE fixes #812

Closed
wants to merge 3 commits into from

Conversation

dibryant
Copy link
Contributor

Fixes for https://issues.redhat.com/browse/RHOAIENG-16520 , https://issues.redhat.com/browse/RHOAIENG-11807 & https://issues.redhat.com/browse/RHOAIENG-16955

Description

Updated setuptools to 70.0.0 for CVE fixes( (unable to update those pipfile.locks that are missing))

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from harshad16 and jstourac December 18, 2024 15:30
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign caponetto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@dibryant: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 4bea150 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atheo89 atheo89 changed the title RHOAIENG-16520, RHOAIENG-11807, RHOAIENG-16955: update setuptools to 70.0.0 for CVE fixes [2024a] RHOAIENG-16520, RHOAIENG-11807, RHOAIENG-16955: update setuptools to 70.0.0 for CVE fixes Dec 19, 2024
@atheo89
Copy link
Member

atheo89 commented Dec 19, 2024

Hey Diamond, The Pipfilelock action is now available on 2024a.
Could you fetch the changes from 2024a, rebase and run that action on your branch for sanity?
Moreover once you have done the above, fix a bit the commit messages.

@jiridanek jiridanek force-pushed the RHOAIENG-16520-2024a branch 2 times, most recently from 8d13cab to 0095fe7 Compare December 19, 2024 12:51
@jiridanek
Copy link
Member

Could you fetch the changes from 2024a, rebase and

I did that, was impatient to see how the newly merged CI runs.

run that action on your branch for sanity?

I did not do that, and maybe I don't have even permissions to trigger actions on somebody else's PR branch. So please do it yourself.

Moreover once you have done the above, fix a bit the commit messages.

Did that too.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dibryant dibryant closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants