-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the pipfile renewal to work when cron firing #811
Make the pipfile renewal to work when cron firing #811
Conversation
@@ -3,9 +3,9 @@ | |||
name: Pipfile.locks Renewal Action | |||
|
|||
on: # yamllint disable-line rule:truthy | |||
# Triggers the workflow every Monday at 22pm UTC am 0 22 * * 1 | |||
# Triggers the workflow every Wednesday at 1am UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe slightly earlier time so that at least America has night would be better, but that doesn't really matter in the end.
/lgtm /override ci/prow/images this test is irrelevant for this PR |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to: https://issues.redhat.com/browse/RHOAIENG-15393
Description
Didn't specify what the gha should do in case of scheduled firing and that's why we got that failure: https://github.com/opendatahub-io/notebooks/actions/runs/12362324472/job/34501399571#step:6:65
Also changed the cron to Wenesday to be closer to release day.
With this update now it works as expected.
How Has This Been Tested?
Tested localy: https://github.com/atheo89/notebooks/actions/runs/12374398338
Merge criteria: