Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-16518: ref(jupyter): deduplicate the Jupyterlab loading spinner code using the improvements put into place just before #801

Merged

Conversation

jiridanek
Copy link
Member

https://issues.redhat.com/browse/RHOAIENG-16518

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…ner code using the improvements put into place just before
@openshift-ci openshift-ci bot requested review from atheo89 and jstourac December 9, 2024 12:39
Copy link
Member

@jstourac jstourac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jiridanek
Copy link
Member Author

/override ci/prow/intel-notebooks-e2e-tests

broken, never passes, we have jira

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/intel-notebooks-e2e-tests

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

broken, never passes, we have jira

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/notebooks-ubi9-e2e-tests

infra issues during build

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebooks-ubi9-e2e-tests

In response to this:

/override ci/prow/notebooks-ubi9-e2e-tests

infra issues during build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/images

never passes

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

never passes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

this one is more likely to succeed, let's retry
/test notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror

@caponetto
Copy link
Contributor

thank you!

/lgtm

@jiridanek
Copy link
Member Author

/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
infra issue

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror

In response to this:

/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
infra issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

thank you both for looking this over

/approve

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek jiridanek added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 11, 2024
@jiridanek
Copy link
Member Author

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"

known test failures, have a ticket for that in Mumbai

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build

In response to this:

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"

known test failures, have a ticket for that in Mumbai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"

known test failures, have a ticket for that in Mumbai

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build
  • build (rocm-jupyter-pytorch-ubi9-python-3.9) / build
  • build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/intel-notebooks-e2e-tests
  • ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-ml-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-minimal-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror
  • ci/prow/notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror
  • ci/prow/notebooks-ubi9-e2e-tests
  • pull-ci-opendatahub-io-notebooks-2023a-images
  • pull-ci-opendatahub-io-notebooks-main-intel-notebooks-e2e-tests
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-min-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-ml-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-ml-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-pyt-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-tf-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi9-python-3-11-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-trustyai-ubi9-python-3-9-pr-image-mirror
  • pull-ci-opendatahub-io-notebooks-main-notebooks-ubi9-e2e-tests
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build"
/override "build (rocm-jupyter-pytorch-ubi9-python-3.9) / build"

known test failures, have a ticket for that in Mumbai

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/intel-notebooks-e2e-tests

broken, never passes, we have jira

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/intel-notebooks-e2e-tests

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

broken, never passes, we have jira

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

/override ci/prow/notebooks-ubi9-e2e-tests

infra issues during build

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebooks-ubi9-e2e-tests

In response to this:

/override ci/prow/notebooks-ubi9-e2e-tests

infra issues during build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member Author

jiridanek commented Dec 11, 2024

it ain't gonna pass, and I ain't gonna be waiting

Test started today at 8:36 AM is still running after 3h19m35s. (more info)

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

it ain't gonna work, and I ain't gonna be waiting

Test started today at 8:36 AM is still running after 3h19m35s. (more info)
/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7419685 into opendatahub-io:main Dec 11, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants