-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-16518: ref(jupyter): deduplicate the Jupyterlab loading spinner code using the improvements put into place just before #801
Conversation
…ner code using the improvements put into place just before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/override ci/prow/intel-notebooks-e2e-tests broken, never passes, we have jira |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/intel-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/notebooks-ubi9-e2e-tests infra issues during build |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebooks-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/images never passes |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
this one is more likely to succeed, let's retry |
thank you! /lgtm |
/override ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebook-jupyter-pytorch-ubi9-python-3-11-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
thank you both for looking this over /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build" known test failures, have a ticket for that in Mumbai |
@jiridanek: Overrode contexts on behalf of jiridanek: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (rocm-jupyter-pytorch-ubi9-python-3.9) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build" known test failures, have a ticket for that in Mumbai |
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/intel-notebooks-e2e-tests broken, never passes, we have jira |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/intel-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/notebooks-ubi9-e2e-tests infra issues during build |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/notebooks-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
it ain't gonna pass, and I ain't gonna be waiting
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7419685
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-16518
Description
How Has This Been Tested?
Merge criteria: