-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Digest Updater Action] Update Notebook Images #565
Conversation
Hi @github-actions[bot]. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
558654b
to
061dfbb
Compare
/lgtm thanks 💯 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
061dfbb
to
be022e2
Compare
New changes are detected. LGTM label has been removed. |
/ok-to-test |
@github-actions[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I can see that the reason why tensorflow was updated wrongly is probably this:
I'll try to check that code to make it a bit more robust; add also Habana into the set for update and execution time 23minutes can be improved, hopefully. |
Everything seems to be order |
Example of the wrong update is opendatahub-io#565, where it had to be updated manually, see the be022e2.
Example of the wrong update is opendatahub-io#565, where it had to be updated manually, see the be022e2.
Example of the wrong update is opendatahub-io#565, where it had to be updated manually, see the be022e2.
🚀 This is an automated Pull Request.
Created by
/.github/workflows/notebooks-digest-updater-upstream.yaml
This PR updates the following files:
manifests/base/params.env
file with the latest updated SHA digests of the notebooks (N & N-1).manifests/base/commit.env
file with the latest commit (N & N-1).❗ IMPORTANT NOTE: Remember to delete the
digest-updater-9521899465
branch after merging the changes