Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digest Updater Action] Update Notebook Images #565

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

🚀 This is an automated Pull Request.
Created by /.github/workflows/notebooks-digest-updater-upstream.yaml

This PR updates the following files:

  • manifests/base/params.env file with the latest updated SHA digests of the notebooks (N & N-1).
  • manifests/base/commit.env file with the latest commit (N & N-1).

IMPORTANT NOTE: Remember to delete the digest-updater-9521899465 branch after merging the changes

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from jiridanek and jstourac June 14, 2024 21:06
@harshad16 harshad16 force-pushed the digest-updater-9521899465 branch from 558654b to 061dfbb Compare June 14, 2024 21:27
@harshad16
Copy link
Member

/lgtm
/approve

thanks 💯

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 force-pushed the digest-updater-9521899465 branch from 061dfbb to be022e2 Compare June 14, 2024 21:30
@openshift-ci openshift-ci bot removed the lgtm label Jun 14, 2024
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

New changes are detected. LGTM label has been removed.

@harshad16
Copy link
Member

/ok-to-test

Copy link
Contributor

openshift-ci bot commented Jun 15, 2024

@github-actions[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests be022e2 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member

jstourac commented Jun 15, 2024

I can see that the reason why tensorflow was updated wrongly is probably this:

CHECKING:  odh-tensorflow-gpu-notebook-image-n
time="2024-06-14T20:32:05Z" level=fatal msg="Error determining repository tags: fetching tags list: invalid status code from registry 502 (Bad Gateway)"

I'll try to check that code to make it a bit more robust; add also Habana into the set for update and execution time 23minutes can be improved, hopefully.

@harshad16
Copy link
Member

Everything seems to be order
Merging this in.

@harshad16 harshad16 merged commit b990fb8 into main Jun 17, 2024
76 of 78 checks passed
jstourac added a commit to jstourac/notebooks that referenced this pull request Jun 19, 2024
Example of the wrong update is opendatahub-io#565, where it had to be updated
manually, see the be022e2.
jstourac added a commit to jstourac/notebooks that referenced this pull request Jun 19, 2024
Example of the wrong update is opendatahub-io#565, where it had to be updated
manually, see the be022e2.
@harshad16 harshad16 deleted the digest-updater-9521899465 branch June 21, 2024 20:42
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/notebooks that referenced this pull request Jun 26, 2024
Example of the wrong update is opendatahub-io#565, where it had to be updated
manually, see the be022e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants