Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the static code checks on push and when manually triggered #547

Conversation

jiridanek
Copy link
Member

Description

GHA that only runs on pull_request is hard to test; I have to create PR to see it run. With this change, the action can be tested in my personal fork before I create a PR.

How Has This Been Tested?

I watched the GHA running, https://github.com/jiridanek/notebooks/actions/runs/9307359587/job/25618467398

The beauty of the morning; silent, bare,
Ships, towers, domes, theaters, and temples lie
Open unto the fields, and to the sky;
All bright and glittering in the smokeless air.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

GHA that only runs on pull_request is hard to test; I have to create PR to see it run.
With this change, the action can be tested in my personal fork before I create a PR
@jstourac
Copy link
Member

/lgtm

Thank you for this change!

@atheo89
Copy link
Member

atheo89 commented Jun 6, 2024

/approve

I don't know why these prow tests got triggered. They shouldn't on this kind of PRs (ref)

/override ci/prow/images
/override ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror
/override ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror
/override ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror, ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror, ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

In response to this:

/approve

I don't know why these prow tests got triggered. They shouldn't on this kind of PRs (ref)

/override ci/prow/images
/override ci/prow/notebook-jupyter-intel-pyt-ubi9-python-3-9-pr-image-mirror
/override ci/prow/notebook-jupyter-intel-tf-ubi9-python-3-9-pr-image-mirror
/override ci/prow/runtime-intel-tf-ubi9-python-3-9-pr-image-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dbd4c21 into opendatahub-io:main Jun 6, 2024
8 checks passed
@jiridanek jiridanek deleted the jd_run_static_checks_on_push_too branch June 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants