Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): mount /etc/hosts to docker #2979

Closed
wants to merge 1 commit into from

Conversation

zztaki
Copy link
Contributor

@zztaki zztaki commented Dec 25, 2023

What problem does this PR solve?

Issue Number: #2978

Problem Summary:
It may download go1.12.8 unsucessfully when build etcdclient in docker.

What is changed and how it works?

What's Changed:
I add relevant parameters to g_docker_opts. At this time, we can specify correct IPs in the local hosts so that the download can be successful in docker.

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@zztaki zztaki changed the title feat(build): mount to docker [skip ci] feat(build): mount to docker Dec 25, 2023
@zztaki zztaki changed the title [skip ci] feat(build): mount to docker feat(build): mount to docker Dec 25, 2023
@zztaki
Copy link
Contributor Author

zztaki commented Dec 25, 2023

cicheck

@zztaki zztaki changed the title feat(build): mount to docker feat(build): mount /etc/hosts to docker Dec 25, 2023
@zztaki
Copy link
Contributor Author

zztaki commented Dec 25, 2023

cicheck

1 similar comment
@zztaki
Copy link
Contributor Author

zztaki commented Dec 26, 2023

cicheck

@zztaki
Copy link
Contributor Author

zztaki commented Dec 27, 2023

cicheck

2 similar comments
@zztaki
Copy link
Contributor Author

zztaki commented Jan 2, 2024

cicheck

@zztaki
Copy link
Contributor Author

zztaki commented Jan 2, 2024

cicheck

@zztaki zztaki closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant