feat(profile): add claude-ads paid-ads suite profile#69
Merged
Conversation
Dedicated profile wiring the full AgriciDaniel/claude-ads suite (v1.7.0): the /ads orchestrator + 22 sub-skills (multi-platform audit, per-platform deep dives across Google/Meta/YouTube/LinkedIn/TikTok/Microsoft/Apple/Amazon, attribution, server-side tracking, creative, landing, budget, plan, competitor, math, test, dna, create, generate, photoshoot). - npx skills use the repo's REAL SKILL.md frontmatter names — the orchestrator is `ads`, not `claude-ads` — so `npx skills add --skill <name>` resolves; `cue validate --online` confirms all 23 are fetchable. - Pairs the claude-ads Claude Code plugin (auto-update + 10 bundled agents) with the npx-materialized copy. - Wires the already-registered google-ads-mcp for optional live, read-only GAQL reads; Meta/LinkedIn/cohnen MCPs documented in the persona as opt-in (claude-ads ships no MCP of its own — manual data works by default). cue validate claude-ads: schema valid, inheritance core -> claude-ads, 27 npx skills resolved, 4 MCPs resolved, 0 errors (only W5 plugin-not- installed-locally warnings).
NagyVikt
commented
Jun 16, 2026
NagyVikt
left a comment
Contributor
Author
There was a problem hiding this comment.
AI code review — APPROVE (no CRITICAL/HIGH)
Single additive declarative file (profiles/claude-ads/profile.yaml, 150 lines). Reviewed across the 7-category checklist:
| Category | Result |
|---|---|
| Correctness | ✅ cue validate --online → schema valid, inheritance core → claude-ads, 27 npx skills resolved (all 23 claude-ads skills fetchable), 4 MCPs resolved |
| Pattern compliance | ✅ Matches seo/google-ads profile shape; name == dirname; description 170 chars (<200); top-level plugins: (not retired skills.plugins) |
| Security | ✅ No inline secrets — all env values are ${...} placeholders (matches the repo's own MCP security guidance) |
| Type safety | ✅ YAML parses; 23 npx skills, mcps:[google-ads-mcp], plugins:[claude-ads@agricidaniel-claude-ads] |
| Completeness | ✅ skills + plugin + mcp + env + persona all declared |
| Maintainability | ✅ Comments explain the ads vs claude-ads orchestrator-name choice and the no-own-MCP situation |
Findings: None CRITICAL/HIGH/MEDIUM/LOW.
Note (informational, not blocking): the orchestrator is wired under its real frontmatter name ads; the pre-existing google-ads/growth/webshop-google profiles list it as claude-ads, which likely doesn't resolve as an npx skill there. Out of scope for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a dedicated
claude-adscue profile that fully wires theAgriciDaniel/claude-adspaid-advertising suite (v1.7.0).Wiring
skills.npx(repo: AgriciDaniel/claude-ads): the/adsorchestrator + 22 sub-skills —
ads-audit, per-platform deep dives(
ads-google,ads-meta,ads-youtube,ads-linkedin,ads-tiktok,ads-microsoft,ads-apple,ads-amazon),ads-attribution,ads-server-side-tracking,ads-creative,ads-landing,ads-budget,ads-plan,ads-competitor,ads-math,ads-test,ads-dna,ads-create,ads-generate,ads-photoshoot.claude-ads@agricidaniel-claude-ads(auto-update + the repo's 10 bundled agents).google-ads-mcp(already in cue's registry) for optional live,read-only GAQL reads. The repo ships no MCP of its own — it works on
manual data by default; Meta/LinkedIn/cohnen MCPs are documented in the
persona as opt-in.
inherits: core; focused persona with the/adsrouter table, the suite'squality gates (3x Kill Rule, Broad-Match-needs-Smart-Bidding, budget
sufficiency, learning-phase protection, Andromeda creative diversity), and
ask-first rules (customer ID / industry / budget).
Correctness note
The skill names match the repo's real SKILL.md
name:frontmatter — theorchestrator is
ads, notclaude-ads(the latter is what the existinggoogle-ads/growth/webshop-googleprofiles list as an npx skill, where itlikely fails to resolve and falls back to the plugin). Not fixing those here —
out of scope.
Validation
cue validate claude-ads:core -> claude-ads--online) — all 23 claude-ads skills resolvegoogle-ads-mcp) · commands 10 · hooks 20W5plugin-not-installed-locally warnings (expected; same as sibling ads profiles)Single additive file:
profiles/claude-ads/profile.yaml.