Skip to content

feat(profile): add claude-ads paid-ads suite profile#69

Merged
NagyVikt merged 1 commit into
mainfrom
worktree-claude-ads-profile
Jun 16, 2026
Merged

feat(profile): add claude-ads paid-ads suite profile#69
NagyVikt merged 1 commit into
mainfrom
worktree-claude-ads-profile

Conversation

@NagyVikt

Copy link
Copy Markdown
Contributor

What

Adds a dedicated claude-ads cue profile that fully wires the
AgriciDaniel/claude-ads paid-advertising suite (v1.7.0).

Wiring

  • 23 skills via skills.npx (repo: AgriciDaniel/claude-ads): the /ads
    orchestrator + 22 sub-skills — ads-audit, per-platform deep dives
    (ads-google, ads-meta, ads-youtube, ads-linkedin, ads-tiktok,
    ads-microsoft, ads-apple, ads-amazon), ads-attribution,
    ads-server-side-tracking, ads-creative, ads-landing, ads-budget,
    ads-plan, ads-competitor, ads-math, ads-test, ads-dna,
    ads-create, ads-generate, ads-photoshoot.
  • Plugin: claude-ads@agricidaniel-claude-ads (auto-update + the repo's 10 bundled agents).
  • MCP: google-ads-mcp (already in cue's registry) for optional live,
    read-only GAQL reads. The repo ships no MCP of its own — it works on
    manual data by default; Meta/LinkedIn/cohnen MCPs are documented in the
    persona as opt-in.
  • inherits: core; focused persona with the /ads router table, the suite's
    quality gates (3x Kill Rule, Broad-Match-needs-Smart-Bidding, budget
    sufficiency, learning-phase protection, Andromeda creative diversity), and
    ask-first rules (customer ID / industry / budget).

Correctness note

The skill names match the repo's real SKILL.md name: frontmatter — the
orchestrator is ads, not claude-ads (the latter is what the existing
google-ads/growth/webshop-google profiles list as an npx skill, where it
likely fails to resolve and falls back to the plugin). Not fixing those here —
out of scope.

Validation

cue validate claude-ads:

  • ✓ schema valid · inheritance core -> claude-ads
  • ✓ npx skills: 27 resolved or fetchable (--online) — all 23 claude-ads skills resolve
  • ✓ MCPs: 4 resolved (incl. google-ads-mcp) · commands 10 · hooks 20
  • 0 errors; only W5 plugin-not-installed-locally warnings (expected; same as sibling ads profiles)

Single additive file: profiles/claude-ads/profile.yaml.

Dedicated profile wiring the full AgriciDaniel/claude-ads suite (v1.7.0):
the /ads orchestrator + 22 sub-skills (multi-platform audit, per-platform
deep dives across Google/Meta/YouTube/LinkedIn/TikTok/Microsoft/Apple/Amazon,
attribution, server-side tracking, creative, landing, budget, plan,
competitor, math, test, dna, create, generate, photoshoot).

- npx skills use the repo's REAL SKILL.md frontmatter names — the
  orchestrator is `ads`, not `claude-ads` — so
  `npx skills add --skill <name>` resolves; `cue validate --online`
  confirms all 23 are fetchable.
- Pairs the claude-ads Claude Code plugin (auto-update + 10 bundled agents)
  with the npx-materialized copy.
- Wires the already-registered google-ads-mcp for optional live, read-only
  GAQL reads; Meta/LinkedIn/cohnen MCPs documented in the persona as opt-in
  (claude-ads ships no MCP of its own — manual data works by default).

cue validate claude-ads: schema valid, inheritance core -> claude-ads,
27 npx skills resolved, 4 MCPs resolved, 0 errors (only W5 plugin-not-
installed-locally warnings).

@NagyVikt NagyVikt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI code review — APPROVE (no CRITICAL/HIGH)

Single additive declarative file (profiles/claude-ads/profile.yaml, 150 lines). Reviewed across the 7-category checklist:

Category Result
Correctness cue validate --online → schema valid, inheritance core → claude-ads, 27 npx skills resolved (all 23 claude-ads skills fetchable), 4 MCPs resolved
Pattern compliance ✅ Matches seo/google-ads profile shape; name == dirname; description 170 chars (<200); top-level plugins: (not retired skills.plugins)
Security ✅ No inline secrets — all env values are ${...} placeholders (matches the repo's own MCP security guidance)
Type safety ✅ YAML parses; 23 npx skills, mcps:[google-ads-mcp], plugins:[claude-ads@agricidaniel-claude-ads]
Completeness ✅ skills + plugin + mcp + env + persona all declared
Maintainability ✅ Comments explain the ads vs claude-ads orchestrator-name choice and the no-own-MCP situation

Findings: None CRITICAL/HIGH/MEDIUM/LOW.

Note (informational, not blocking): the orchestrator is wired under its real frontmatter name ads; the pre-existing google-ads/growth/webshop-google profiles list it as claude-ads, which likely doesn't resolve as an npx skill there. Out of scope for this PR.

@NagyVikt NagyVikt merged commit 3ad34cb into main Jun 16, 2026
4 of 5 checks passed
@NagyVikt NagyVikt deleted the worktree-claude-ads-profile branch June 16, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant