Skip to content

test: add missed use of for range over integers #4950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2025
Merged

test: add missed use of for range over integers #4950

merged 1 commit into from
Oct 25, 2025

Conversation

@ariel-anieli
Copy link
Contributor

@ariel-anieli ariel-anieli commented Oct 23, 2025 •
edited
Loading

The commit mentioned below has missed these changes.

Fixes: 1757062 ("Use for range over integers")
Signed-off-by: Ariel Otilibili [email protected]

@ariel-anieli
Copy link
Contributor Author

ariel-anieli commented Oct 23, 2025 •
edited
Loading

All the test failures are about CRIU: here, or even here (I noticed this one with a make test on my local machine).

It seems related to this key retrieval in Dockerfile.

cyphar
cyphar reviewed Oct 23, 2025
View reviewed changes
@ariel-anieli
libcontainer/seccomp: Use for range over integers
34da991 
The commit mentioned below has missed these changes.

Fixes: 1757062 ("Use for range over integers")
Signed-off-by: Ariel Otilibili <[email protected]>
@lifubang lifubang changed the title libcontainer/seccomp: Use for range over integers test: add missed use of for range over integers Oct 23, 2025
@lifubang
Copy link
Member

Thanks, if you can change the commit subject to ‘ test: add missed use of for range over integers’, it will be better.

@ariel-anieli
Copy link
Contributor Author

Thanks, if you can change the commit subject to ‘ test: add missed use of for range over integers’, it will be better.

Thank you, @lifubang. The tests had no failure on the second run. Is that expected?

@ariel-anieli ariel-anieli requested a review from cyphar October 23, 2025 10:53
@lifubang
Copy link
Member

Is that expected?

No, I saw a service status 503 when installing the dependencies, and a flaky test for testing criu dev branch. All are not related to your PR.

kolyshkin
kolyshkin approved these changes Oct 25, 2025
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (for some reason modernize ignores this, I can't see why)

@AkihiroSuda AkihiroSuda added the backport/1.4-todo A PR in main branch which needs to backported to release-1.4 label Oct 25, 2025
@AkihiroSuda AkihiroSuda merged commit 644bb1e into opencontainers:main Oct 25, 2025
142 of 150 checks passed
@ariel-anieli
Copy link
Contributor Author

Thanks, if you can change the commit subject to ‘ test: add missed use of for range over integers’, it will be better.

I have realized the commit went in with the title unchanged, @lifubang; I'll remember that for the next time.

@ariel-anieli
Copy link
Contributor Author

Thanks to you all.

@ariel-anieli ariel-anieli deleted the loop-range-integers branch October 25, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyphar cyphar cyphar approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

backport/1.4-todo A PR in main branch which needs to backported to release-1.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ariel-anieli @lifubang @cyphar @kolyshkin @AkihiroSuda