tests/int: use run -N|! for runc
#4946
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of tests/integration cleanup I wanted to do for quite some time.
For the first part, see #4945.
Improve runc wrapper
Add status check support (same as in bats' run helper).
Add PRE_CMD support (so we can use commands like taskset or timeout).
Drop sane_helper since the output of the command is shown in case of
an error, and we show the command itself in runc wrapper (unless -N
or ! is provided -- in this case the command is shown by bats,
together with the error). This does not show the output of successful
commands which IMO is a net positive since we are almost always
interested in failed command output only.
Use the new functionality in cpu_affinity.bats and start.bats as a
showcase (the test of refactoring is in a separate commit).
refactor to use runc status checks
add missing runc status checks