Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused config container under /system/alarms mislabeled as config=false #1212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earies
Copy link
Contributor

@earies earies commented Nov 1, 2024

  • (M) release/models/system/openconfig-alarms.yang
    • Remove config container and retain entire hierarchy for alarms as
      read-only

Change Scope

The current published /system/alarms hierarchy is tagged as read-only however
a config container grouping was introduced to follow common OC style. This
config container inherited the r/o attributes of it's parent as a result.

We have a few options here:

  1. Move config=false down to the state container and leave the entire list as
    r/w potentially accomodating future configuration (There could potentially
    be some attributes that you could tag an ID with in some implementations to
    suppress, change behavior, etc..)
  2. Keep the entire hierarchy as config=false and thus remove any possibility
    for configuration. This is similar to other hierarchies such as /system/cpus

Platform Implementations

N/A: Bug

…fig=false

  * (M) release/models/system/openconfig-alarms.yang
    - Remove config container and retain entire hierarchy for alarms as
      read-only
@earies earies requested a review from a team as a code owner November 1, 2024 16:39
@dplore
Copy link
Member

dplore commented Nov 1, 2024

/gcbrun

@OpenConfigBot
Copy link

No major YANG version changes in commit cb68be2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants