Fix cpp translate #78
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some tests? |
|
yep just added some, Yuyou |
|
@math-fehr, I added a feature in the lowering section that Yuyou and I need for the eval section of our POPL submission, also it seems like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering from MLIR to C++ has been broken in the upstream xdsl-smt repo for a quite some, while the synthesizing transfer functions repository has made a bunch of project specific changes to the lowering. This PR aims to fix the lowering in the xdsl-smt repo, without adding any synth-transformers specific code.
Note that type checking has been turned back on in
xdsl_smt/utils/lower_utils.pyandxdsl_smt/passes/transfer_lower.pywhich will hopefully make this more maintainable in the future.Also I do not have a huge corpus of MLIR files on my machine, so further testing would be hugely appreciated