feat(Rewriter): introduce replaceOp! and simplify RV-Isel#966
Merged
Conversation
Contributor
There was a problem hiding this comment.
VeIR Benchmarks
Details
| Benchmark suite | Current: 767bdc2 | Previous: 2e6fd0e | Ratio |
|---|---|---|---|
add-fold-worklist/create |
1854000 ns (± 89153) |
1888000 ns (± 80235) |
0.98 |
add-fold-worklist/rewrite |
3559500 ns (± 130022) |
3574000 ns (± 71484) |
1.00 |
add-fold-worklist-local/create |
1834000 ns (± 104222) |
1849000 ns (± 37499) |
0.99 |
add-fold-worklist-local/rewrite |
2965000 ns (± 50303) |
2993000 ns (± 17436) |
0.99 |
add-zero-worklist/create |
1816500 ns (± 112188) |
1846000 ns (± 60021) |
0.98 |
add-zero-worklist/rewrite |
2264500 ns (± 90482) |
2263000 ns (± 62874) |
1.00 |
add-zero-reuse-worklist/create |
1504000 ns (± 31169) |
1539000 ns (± 23512) |
0.98 |
add-zero-reuse-worklist/rewrite |
1894000 ns (± 29022) |
1878000 ns (± 25066) |
1.01 |
mul-two-worklist/create |
1823000 ns (± 25745) |
1826000 ns (± 92191) |
1.00 |
mul-two-worklist/rewrite |
4905000 ns (± 18690) |
5029000 ns (± 87674) |
0.98 |
add-fold-forwards/create |
1798000 ns (± 67020) |
1874000 ns (± 88720) |
0.96 |
add-fold-forwards/rewrite |
2686000 ns (± 50599) |
2738000 ns (± 65269) |
0.98 |
add-zero-forwards/create |
1826000 ns (± 43420) |
1845000 ns (± 93569) |
0.99 |
add-zero-forwards/rewrite |
1754000 ns (± 12349) |
1766000 ns (± 28078) |
0.99 |
add-zero-reuse-forwards/create |
1508000 ns (± 14053) |
1575000 ns (± 75401) |
0.96 |
add-zero-reuse-forwards/rewrite |
1411000 ns (± 32277) |
1407000 ns (± 63837) |
1.00 |
mul-two-forwards/create |
1840000 ns (± 80949) |
1845500 ns (± 92486) |
1.00 |
mul-two-forwards/rewrite |
3275000 ns (± 96336) |
3293000 ns (± 84379) |
0.99 |
add-zero-reuse-first/create |
1502000 ns (± 51355) |
1543500 ns (± 23873) |
0.97 |
add-zero-reuse-first/rewrite |
9000 ns (± 447) |
10000 ns (± 2608) |
0.90 |
add-zero-lots-of-reuse-first/create |
1509000 ns (± 29558) |
1547000 ns (± 12779) |
0.98 |
add-zero-lots-of-reuse-first/rewrite |
761000 ns (± 20120) |
765000 ns (± 12510) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
39cb138 to
767bdc2
Compare
math-fehr
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/InstructionSelection/RISCV.leanis now sorry-free.