Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GitHub workflows #1397

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Upgrade GitHub workflows #1397

merged 4 commits into from
Aug 6, 2024

Conversation

Midnighter
Copy link
Member

@Midnighter Midnighter commented Aug 5, 2024 •
edited by cdiener
Loading

Main changes

Upgrade the GitHub workflows in the following ways:

  • Create a reusable test workflow
  • Run tests on push and PR
  • Run release on pushed tags
  • Run a weekly test job, so we can notice problems sooner
  • Rely on OIDC tokens for publishing to PyPI

Other

Fixes the use of a deprecated numpy type check. This will work with numpy 1.

@Midnighter Midnighter requested a review from cdiener August 5, 2024 18:01
@Midnighter Midnighter self-assigned this Aug 5, 2024
cdiener
cdiener approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@cdiener cdiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine now.

@cdiener cdiener merged commit 5bc58c9 into devel Aug 6, 2024
7 checks passed
@cdiener cdiener deleted the upgrade-workflows branch August 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdiener cdiener cdiener approved these changes

Assignees

@Midnighter Midnighter

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Midnighter @cdiener