Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

dont interpolate nwp data #338

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 5, 2021

Pull Request

Description

Stop NWP interpolation

Fixes #135

How Has This Been Tested?

Unittests, + adjusted unittest for desired results

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 5, 2021 09:46
@peterdudfield peterdudfield self-assigned this Nov 5, 2021
@peterdudfield peterdudfield marked this pull request as draft November 5, 2021 09:58
@peterdudfield peterdudfield marked this pull request as ready for review November 5, 2021 11:12
@peterdudfield
Copy link
Contributor Author

This should help reduce MB for the nwp data.

Copy link
Member

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@@ -57,7 +57,7 @@ def __post_init__(self):
assert self.forecast_length >= 0
assert self.history_minutes % self.sample_period_minutes == 0, (
f"sample period ({self.sample_period_minutes}) minutes "
f"does not fit into historic minutes ({self.forecast_minutes})"
f"does not fit into historic minutes ({self.history_minutes})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@peterdudfield peterdudfield merged commit 7bcdbd3 into main Nov 8, 2021
@peterdudfield peterdudfield deleted the issue/135-remove-nwp-temporary branch November 8, 2021 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Turn off temporal interpolation of numerical weather predictions (NWPs)
2 participants