This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Add Local Filesystem Support #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbieker
added
enhancement
|
Nice! And good timing, as we'll need this next week to get the code running on OCF ML server :) |
JackKelly
reviewed
Sep 17, 2021
| @@ -159,15 +159,15 @@ def __init__( | |||
| self.gcs = None | |||
| self.s3_resource = None | |||
|
|
|||
| assert cloud in ["gcp", "aws"] | |||
| assert cloud in ["gcp", "aws", "local"] | |||
There was a problem hiding this comment.
I wonder if we should rename cloud to compute_environment or something like that? cloud = 'local' feels a bit weird. I don't have a strong opinion though!
There was a problem hiding this comment.
If we are going for being explicit, then probably should be compute_environment, but our own stuff is still just our own local cloud too!
There was a problem hiding this comment.
Yeah, true! So, yeah, I really don't mind what we do here. Very happy to stick with cloud!
JackKelly
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Allows nowcasting-dataset to read files locally, without needing to get them from GCS or AWS.
Relates to issue #121
How Has This Been Tested?
Unit test
Checklist: