Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Issue/342 manger test #363

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Issue/342 manger test #363

merged 6 commits into from
Nov 10, 2021

Conversation

@peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 10, 2021 •
edited
Loading

Pull Request

Description

add tests for manager

  • test that checks batches are made
  • test that checks config is saved

Want to do this before #341

Fixes #324

How Has This Been Tested?

normal unit test

  • addition ones for this PR
  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 10, 2021 15:04
jacobbieker
jacobbieker approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit fd6a1e8 into main Nov 10, 2021
@peterdudfield peterdudfield deleted the issue/342-manger-test branch November 10, 2021 16:12
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Nov 10, 2021

@JackKelly just merging this in, so that it can be used in #314

This was referenced Nov 10, 2021
Open
Closed
JackKelly
JackKelly reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@JackKelly JackKelly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@JackKelly JackKelly JackKelly left review comments

@jacobbieker jacobbieker jacobbieker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document new architecture (including a diagram)

4 participants

@peterdudfield @JackKelly @jacobbieker