feat(search): add turbovec vector backend - #83
Conversation
|
Codex review: found issues before merge. Reviewed June 7, 2026, 10:57 PM ET / 02:57 UTC. Summary Reproducibility: not applicable. This PR adds a new optional backend rather than reporting broken existing behavior. Source inspection shows current main has no vector backend selector. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the crawlkit backend first, tag it, update discrawl to that tag, remove the direct CHANGELOG edit, and keep exact scoring as the default with a focused turbovec smoke before release. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR adds a new optional backend rather than reporting broken existing behavior. Source inspection shows current main has no vector backend selector. Is this the best way to solve the issue? Unclear until the release dependency is resolved: reusing crawlkit Full review comments:
Overall correctness: patch is correct AGENTS.md: not found in the target repository. Codex review notes: model gpt-5.5, reasoning high; reviewed against f1ca1ceabac1. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Thanks @vincentkoc. I landed this via maintainer PR #88 as commit 1916f8e because this PR branch has What landed:
For future PRs, enabling “Allow edits by maintainers” lets maintainers update dependency pins or fix CI directly on the contributor branch. |
Summary
Adds optional turbovec-backed semantic scoring for discrawl.
[search.embeddings].vector_backendwithexactas the defaultturbovecdependency and dimensions-divisible-by-8 contractRelease order
Depends on openclaw/crawlkit#18. Before discrawl release, replace the crawlkit pseudo-version with the final crawlkit release tag.
Verification
GOWORK=off go test -count=1 ./...discrawl --helpdiscrawl --versiondiscrawl metadata --jsondiscrawl status --jsondiscrawl tui --json