fix: prevent global coverage timeouts on large archives#146
Merged
steipete merged 1 commit intoJul 21, 2026
Merged
Conversation
Collaborator
|
Landed as Verification on exact PR head
Hosted checks were green on the exact PR head:
No dependency files changed. No release or deployment action was performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A scheduled incremental snapshot refresh completed its import successfully, then failed closed during post-maintenance validation because global
coverage --jsonexceeded its internal deadline. The affected archive was 8.39 GB with about 1.39 million messages and 27.8k channels. The failed run preserved all 2,323,757 preexisting identities, added only 2 messages, and reportedquery channel coverage: context deadline exceeded. An immediate warm retry completed successfully.Upstream
maincurrently gives every coverage query the same 2-minute deadline and uses a channel-first aggregate for both filtered and global reports. On a large global archive, that shape can repeatedly walk message indexes per channel and leave too little cold-cache margin.Fix
Validation
go test ./...go vet ./...go test ./internal/store -run TestCoverage -count=1coverage --jsonagainst the live 8.39 GB archive: exit 0 in 27.93 seconds.messagesscan rather than selecting either channel index.No crawl, sync, import, publish, vacuum, checkpoint, integrity scan, schema change, or archive mutation is introduced by this patch.