Skip to content

fix(cli): clarify missing required configuration - #129

Merged
steipete merged 2 commits into
mainfrom
clawsweeper/issue-openclaw-discrawl-128
Jul 16, 2026
Merged

fix(cli): clarify missing required configuration#129
steipete merged 2 commits into
mainfrom
clawsweeper/issue-openclaw-discrawl-128

Conversation

@clawsweeper

@clawsweeper clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace raw missing-file errors for configuration-dependent live commands with actionable guidance
  • include the resolved configuration path and suggest discrawl init, --config, and DISCRAWL_CONFIG
  • preserve malformed TOML, permission failures, and other filesystem errors unchanged
  • add focused regression coverage with isolated HOME/XDG directories

Validation

  • GOWORK=off go test ./internal/cli
  • GOWORK=off go test ./...

Thanks @0xdevalias for the report and reproduction in #128.

Fixes #128

@clawsweeper clawsweeper Bot added clawsweeper Tracked by ClawSweeper automation clawsweeper:autogenerated PR created automatically by ClawSweeper clawsweeper:autofix Maintainer opted this PR into bounded ClawSweeper-reviewed autofix without merge labels Jul 14, 2026
@clawsweeper

clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

🦞🧹
ClawSweeper autofix is enabled.

  • Head: 857385d1c040
  • Label: clawsweeper:autofix
  • Action: exact-head review queued (workflow sweep.yml, event repository_dispatch).
  • Flow: review this head, repair/rebase only if needed, then re-review the exact repaired head until no actionable findings remain.

This is fix-only; I will not merge this PR.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal priority bug or improvement with limited blast radius. labels Jul 14, 2026
@clawsweeper

clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Codex review: needs maintainer review before merge. Reviewed July 14, 2026, 8:28 PM ET / July 15, 2026, 00:28 UTC.

Summary
The PR converts missing configuration-file errors in shared CLI service operations into actionable setup guidance and adds regression coverage for missing and malformed configurations.

Reproducibility: yes. at source level: running tail without the resolved configuration file reaches the shared loader and returns the raw missing-file error on current main. The linked report supplies the concrete observed command and output, although this review did not execute it locally.

Review metrics: 2 noteworthy metrics.

  • Patch scope: 2 files; 34 added, 1 removed. The change is narrowly limited to shared CLI error handling and its focused regression tests.
  • Validation: 10 successful check runs. The complete reported CI suite passed on the exact reviewed head.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #128
Summary: This PR is the explicit candidate fix for the linked missing-configuration CLI issue.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • No automated repair remains; the clean implementation needs ordinary owner review and a merge decision.

Security
Cleared: The patch changes Go error handling and tests only, with no dependency, workflow, permission, secret, downloaded-code, or supply-chain changes.

Review details

Best possible solution:

Merge the focused shared-wrapper fix after owner review so configuration-dependent commands consistently show the resolved path and supported recovery choices without masking unrelated loading failures.

Do we have a high-confidence way to reproduce the issue?

Yes at source level: running tail without the resolved configuration file reaches the shared loader and returns the raw missing-file error on current main. The linked report supplies the concrete observed command and output, although this review did not execute it locally.

Is this the best way to solve the issue?

Yes. Handling only os.ErrNotExist in the existing shared operation wrapper is the narrowest maintainable fix and avoids changing general configuration parsing or masking malformed files and permission failures.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against 0dc6a87cad9a.

Label changes

Label justifications:

  • P2: The PR fixes a reproducible but bounded CLI usability problem without affecting data integrity, security, or runtime availability.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The PR is bot-authored, so the external-contributor real-behavior proof gate does not apply; the successful focused and full Go tests provide supplemental validation.
Evidence reviewed

What I checked:

Likely related people:

  • steipete: Public repository history and the PR timeline connect this person with the project and the central CLI surface, making them the strongest available routing candidate for final behavior review. (role: feature owner; confidence: medium; files: internal/cli/cli.go, internal/cli/cli_test.go)
  • vincentkoc: Public repository history shows recent substantial work in the CLI area, so they are a useful secondary reviewer for shared runtime behavior and regression coverage. (role: recent CLI area contributor; confidence: medium; commits: 01b1053809c4; files: internal/cli/cli.go)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (25 earlier review cycles; latest 8 shown)
  • reviewed 2026-07-14T22:25:10.630Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T22:41:33.716Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T22:56:07.273Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T23:12:26.836Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T23:26:30.818Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T23:41:27.040Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-14T23:56:38.518Z sha 857385d :: needs maintainer review before merge. :: none
  • reviewed 2026-07-15T00:12:49.886Z sha 857385d :: needs maintainer review before merge. :: none

@clawsweeper clawsweeper Bot removed the clawsweeper:autofix Maintainer opted this PR into bounded ClawSweeper-reviewed autofix without merge label Jul 14, 2026
@clawsweeper

clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

🦞✅
ClawSweeper autofix is complete for this exact head.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=857385d1c040f2fb2b8d264a4e8275d36186fbb3)
Head: 857385d1c040

No actionable findings remain. I removed the repair-loop label and left the PR open for maintainer review and merge.

Automerge progress:

  • 2026-07-14 16:15:16 UTC review passed 857385d1c040 (structured ClawSweeper verdict: pass (sha=857385d1c040f2fb2b8d264a4e8275d36186f...)

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jul 14, 2026
@steipete

Copy link
Copy Markdown
Collaborator

Maintainer verification on exact head 37728e576fc95106ac63d375206c37cd2f3a0775:

  • Current-main reproduction: built ./cmd/discrawl, ran tail with isolated HOME/XDG directories and no config; observed exit 3 plus raw open .../config.toml: no such file or directory.
  • PR live proof: built the real binary, ran the same isolated tail; observed exit 3 plus the resolved config path and guidance for discrawl init, --config <path>, and DISCRAWL_CONFIG.
  • Focused test: GOWORK=off go test ./internal/cli passed.
  • Full suite: GOWORK=off go test ./... passed.
  • AutoReview: .agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --stream-engine-output reported no accepted/actionable findings.
  • Added the required 0.11.6 - Unreleased changelog entry, crediting @0xdevalias.

No merge performed; ready for maintainer landing after hosted checks complete.

@steipete
steipete merged commit 0ed81ed into main Jul 16, 2026
10 checks passed
@steipete
steipete deleted the clawsweeper/issue-openclaw-discrawl-128 branch July 16, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clawsweeper:autogenerated PR created automatically by ClawSweeper clawsweeper Tracked by ClawSweeper automation P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve discord tail / similar to not crash with a "no such file or directory" error while looking for config.toml

1 participant