Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-6014 - Sample Genotypes columns are hidden in SVB in some circunstancies #902

Merged
merged 9 commits into from
Apr 16, 2024
Merged

TASK-6014 - Sample Genotypes columns are hidden in SVB in some circunstancies #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
397320d
wc: exclude sample genotypes columns from settings in variant-interpr…
jmjuanes Apr 10, 2024
d9081de
wc: exclude from settings vcf file data columns in variant-interprete…
jmjuanes Apr 10, 2024
35039e4
wc: exclude from settings vcf file data columns in variant-interprete…
jmjuanes Apr 10, 2024
6272cde
wc: using configuration variable to control when sample genotypes col…
jmjuanes Apr 10, 2024
ddf2469
wc: using configuration variable to control when vcf file data column…
jmjuanes Apr 10, 2024
72ba0f1
wc: using configuration variable to control when vcf file data column…
jmjuanes Apr 10, 2024
12b088f
wc: remove commented code in variant-interpreter-rearrangement-grid #…
jmjuanes Apr 10, 2024
9e466b5
wc: remove commented code in variant-interpreter-grid #TASK-6014
jmjuanes Apr 10, 2024
8c1e2e6
Merge branch 'release-2.12.x' into TASK-6014
jmjuanes Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/webcomponents/variant/interpretation/variant-interpreter-grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,8 @@ export default class VariantInterpreterGrid extends LitElement {
colspan: 1,
formatter: this.vcfDataFormatter,
halign: this.displayConfigDefault.header.horizontalAlign,
visible: this.gridCommons.isColumnVisible(columnId, "VCF_Data"),
excludeFromSettings: true,
visible: !this._config.hideVcfFileData,
});
}
}
Expand Down Expand Up @@ -1082,7 +1083,8 @@ export default class VariantInterpreterGrid extends LitElement {
formatter: VariantInterpreterGridFormatter.sampleGenotypeFormatter,
align: "center",
nucleotideGenotype: true,
visible: this.gridCommons.isColumnVisible(samples[i].id, "sampleGenotypes"),
excludeFromSettings: true,
visible: !this._config.hideSampleGenotypes,
});
}
}
Expand Down Expand Up @@ -1131,7 +1133,8 @@ export default class VariantInterpreterGrid extends LitElement {
formatter: VariantInterpreterGridFormatter.sampleGenotypeFormatter,
align: "center",
nucleotideGenotype: true,
visible: this.gridCommons.isColumnVisible(samples[i].id, "sampleGenotypes"),
excludeFromSettings: true,
visible: !this._config.hideSampleGenotypes,
});
}
}
Expand Down Expand Up @@ -1549,6 +1552,8 @@ export default class VariantInterpreterGrid extends LitElement {
hidePopulationFrequencies: false,
hideClinicalInfo: false,
hideDeleteriousness: false,
hideSampleGenotypes: false,
hideVcfFileData: false,

quality: {
qual: 30,
Expand Down
4 changes: 3 additions & 1 deletion src/webcomponents/variant/interpretation/variant-interpreter-rearrangement-grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,8 @@ export default class VariantInterpreterRearrangementGrid extends LitElement {
colspan: 1,
formatter: (value, row) => this.vcfDataFormatter(value, row[index], field),
halign: "center",
visible: this.gridCommons.isColumnVisible(id),
excludeFromSettings: true,
visible: !this._config.hideVcfFileData,
});
});
});
Expand Down Expand Up @@ -1104,6 +1105,7 @@ export default class VariantInterpreterRearrangementGrid extends LitElement {
showActions: false,
multiSelection: false,
nucleotideGenotype: true,
hideVcfFileData: false,

alleleStringLengthMax: 50,

Expand Down
Loading