CADC-13577 rename tap_schema.columns id column to column_id #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jburke-cadc
commented
Dec 19, 2024
•
jburke-cadc
commented
- the namespace is TBD
jburke-cadc
changed the title
pdowler
reviewed
Jan 13, 2025
There was a problem hiding this comment.
The name of the upgrade file and the comment suggest these changes are in 1.2.2 but the currently released cadc-tap-schema is 1.2.3 ... head of main has 1.2.4 already because of previous un-released work (VOSI-tables output votable).
This PR has changed column name but I do not see any code changes in cadc-tap-schema. There must be changes in InitDatabaseTS and in TapSchemaDAO (which references the id column). The TapSchemaDAOTest intTest will run InitDatabaseTS to either create or upgrade the tap_schema structure and you make sure to test both of those.
pdowler
reviewed
Jan 14, 2025
pdowler
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.