Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge conflict action and update action version #995

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Jul 1, 2024

Description

Added a merge conflict labeler workflow for all the PR when a merge conflict is detected so people can resolve it when commit on master branch is made.
And update action version to remove the warning.

merge-conflict label need to be made before merging this PR

@openbullet
Copy link
Owner

The publish.yaml workflow is outdated and doesn't get executed anymore, I will remove it at some point. Thanks for the labeler and the action updates.

with:
dirtyLabel: 'merge-conflict'
commentOnDirty: 'This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.'
repoToken: '${{ secrets.GITHUB_TOKEN }}'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such secret at the moment in the repo, is it something that is automatically defined or do I have to create a fine-grained token? Do you have more information on this?

Copy link
Contributor Author

@Gauvino Gauvino Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. To follow your previous comment should I remove the publish.yaml ? (Edit: did removed the change in the publish.yaml)
  2. The token is automatically created by Github, no need to setup anything more than just the merge-conflict label

@openbullet openbullet merged commit e7bc766 into openbullet:master Jul 1, 2024
@Gauvino Gauvino deleted the github-action branch July 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants