Switched to AsyncKeyedLock

[MarkCiliaVincenti]

This PR will reduce memory allocations and memory usage.

[MarkCiliaVincenti]

@openbullet :)

[openbullet]

Hey sorry I didn't have time to look into this yet, will do soon ^^'

[MarkCiliaVincenti]

Hey sorry I didn't have time to look into this yet, will do soon ^^'

gentle reminder :)

[meinname]

@openbullet asked me to try it.
And i noticed that jobs don't start as they don't load proxies. - without proxies it seems to be ok. (tho i did no extensive test without being able to use proxies)
(Tested on native)

[MarkCiliaVincenti]

@openbullet asked me to try it. And i noticed that jobs don't start as they don't load proxies. - without proxies it seems to be ok. (tho i did no extensive test without being able to use proxies) (Tested on native)

Hi,

What would be the easiest way to reproduce this issue please so that I could maybe debug? Or would you kindly be able to debug and tell me where the issue lies please?

[MarkCiliaVincenti]

@meinname

[meinname]

Simply try to start a job with proxies.
It wont start

[MarkCiliaVincenti]

@meinname I'm going to need more info to replicate this issue please. Also can you try again please?

[MarkCiliaVincenti]

@meinname please let me know. I've also updated to the latest version of the library with performance improvements.

[meinname]

Still. When starting a Job with proxies off it seems to work.
But as soon as i use proxies (tested from OB2 Proxy Manager and from File) a Job with a simple config only remains at Starting...
(only did a quick test this time on native Client on Windows)

[MarkCiliaVincenti]

Would you be so kind as to dumb it down into steps with screenshots to reproduce? And can you confirm that without the PR it does not give an issue?

[meinname]

I don't know hot to dumb it down more - but i try

First i check out ob2 master to a new directory and publish it to a new directory.
Then i start the native client and create a new config - basically anything you want. - i just used one as simple as that one:

BLOCK:RandomInteger
  => VAR @randomIntegerOutput
ENDBLOCK

BLOCK:Keycheck
  KEYCHAIN SUCCESS OR
    INTKEY @randomIntegerOutput GreaterThanOrEqualTo 9
  KEYCHAIN FAIL OR
    INTKEY @randomIntegerOutput LessThan 9
ENDBLOCK

and add a few simple proxies on ob2 proxy tab to a new group.
As they aren't used with this config, i just add some like 127.0.0.1:9000 127.0.0.1:9001 .... or real ones or whatever.

I create a new multirun job and
select the config. - set bots to 10 - proxy mode to on - wordlist either use one via file or just use infinite
And then go to the job and start it.
It works. - job runs and you get successes and fails

then do the same but with the PR merged
And then you can see that after pressing start ob2 does nothing. Beside job status is and stays on "Starting..."
Edit: oh, and if i do the same and switch proxy mode to off it works

[MarkCiliaVincenti]

That looks very helpful actually @meinname, thanks I'll look at it probably over the weekend.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[Gauvino]

@MarkCiliaVincenti Hello, first thank for your contribution, could please resolve the merge conflict to get this reviewed ?

[MarkCiliaVincenti]

I took a look at the updated code and I tried my best to see how I could get the AsyncKeyedLock library to work with OpenBullet2 but I don't understand what that LoliCodeBlockInstance is.

More importantly for you guys is that the current AsyncLocker class is not just very inefficient but worse than that has obvious race conditions.

You will need to refactor your code.