Skip to content

feat(selenium): Add edge browser type #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

keleskutay
Copy link

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Basically, i have tried with head and headless type with test config. It works as expected.

Checklist:

  • [X ] My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@keleskutay keleskutay changed the base branch from master to staging March 20, 2025 16:32
@openbullet
Copy link
Owner

Hello, thanks for the PR. How does OB2 benefit from the addition of Edge? Is there anything in particular that it does better than Chrome, even if both are Chromium-based?

@keleskutay
Copy link
Author

Hello, thanks for the PR. How does OB2 benefit from the addition of Edge? Is there anything in particular that it does better than Chrome, even if both are Chromium-based?

That's a good point—since both browsers are Chromium-based, there shouldn't be any major differences in functionality. However, some users might not have Chrome installed and prefer to use Edge since it comes pre-installed with Windows. That’s the main reason I added Edge support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants