Enum with Root Types Filtering Recursive Reference #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 3fabebe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ParkerVR
added a commit
to Equal-IQ/api-model
that referenced
this pull request
Jul 14, 2025
…ypescript#2375 This reverts commit 175d90d.
|
I added some snapshot tests here since this change is a bit particular to CLI Flag Combination, though I guess it could be inlined instead like some of the other partial api spec examples. I'll leave it to maintainers to decide on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Using the --enum and --root-types in combination causes recursive reference to enum types used in schemas, breaking the file.
A few issues related:
#2099
#2341
How to Review
A specific combination of flags causes recursive imports, marked as patch since it seems incredibly unlikely anyone could successfully use this output in a production system. Had a custom in my project and was trying to use the flags instead, but the combined behavior broke me. https://github.com/Equal-IQ/api-model/blob/e99585b6244ac814ea1044f62333474a5857c3b8/Containers/generate.js
Checklist
docs/updated (if necessary) don't think any change is required, as this is a reasonable expected behaviorpnpm run update:examplesrun (only applicable for openapi-typescript) no changes required to these, since the combination is not used for them