Issue openam#205 Upgrade jQuery to new version#14
Draft
tsujiguchitky wants to merge 11 commits intomasterfrom
Draft
Issue openam#205 Upgrade jQuery to new version#14tsujiguchitky wants to merge 11 commits intomasterfrom
tsujiguchitky wants to merge 11 commits intomasterfrom
Conversation
* QUnit 1.15.0 -> 2.10.0 * grunt-contrib-qunit -> 0.4.0 -> 3.1.0 * grunt-contrib-requirejs 0.4.4 -> 1.0.0 * Node.js 4.2.6 -> 6.4.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
openam-jp/openam#205
jQuery is an important component that affects XUI and other javascript libraly.
jQuery which OpenAM includes is an old version and does not reflect the latest improvements.
And to update jQuery, this project also needs to be modified.
Solution
Upgrade jQuery to 3.5.1 and fixed problems due to following specification changes.
And also updated the following libraries and frameworks:
Compatibility
The updated version of grunt-contrib-qunit now uses Puppeteer as a headless browser.
Therefore, the libraries required for Puppeteer must be installed in the build environment.
See https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md#troubleshooting
Testing
Unit tests works fine.