Refactor config access around an Ecto schema#41
Merged
frantic-openai merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
Summary: - replace the WORKFLOW.md config parser with nested Ecto embedded schemas and field-level defaults - centralize env, path, and sandbox post-processing in a single schema pipeline - update config validation tests and orchestrator logging for the new strict invalid_workflow_config path Rationale: - NimbleOptions was carrying a large amount of custom extraction and fallback code that duplicated schema behavior - Ecto gives nested typed validation directly and makes the remaining config behavior easier to reason about - consolidating the config flow removes silent compatibility logic and makes failures explicit Tests: - cd elixir && mix test --warnings-as-errors - cd elixir && mix credo --strict Co-authored-by: Codex <codex@openai.com>
Summary: - collapse Config down to settings/settings! plus the remaining runtime helpers - switch callers and tests to use nested schema structs instead of the field-by-field getter layer - tighten the schema around codex.command and add the specs and tests needed for the full make all pipeline Rationale: - make the Ecto schema the source of truth for config shape and defaults - remove the extra access hop so config reads are direct and typed - keep the repo green under formatting, lint, coverage, and dialyzer Tests: - cd elixir && make all Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The config layer had grown around NimbleOptions and a large getter surface. This branch moves parsing to an Ecto schema and simplifies callers to read typed nested settings directly.
TL;DR
Replace the bespoke config access layer with an Ecto-backed schema and typed settings access.
Summary
Configdown tosettings/0,settings!/0, and a small runtime helper surfaceAlternatives
make -C elixir allred on coverage and dialyzerTest Plan
make -C elixir allcd elixir && mix test test/symphony_elixir/workspace_and_config_test.exs --warnings-as-errors