Skip to content

Support app-owned enum tweaks - #496

Merged
rz-openai merged 1 commit into
mainfrom
codex/app-owned-enum-tweaks
Oct 8, 2026
Merged

rz-openai merged 1 commit into
mainfrom
codex/app-owned-enum-tweaks

Conversation

@rz-openai

Copy link
Copy Markdown
Collaborator

Enum-valued TweakSource bindings fail when the registry reads them, so the Tweaks endpoint cannot serve controls. Support app-owned enums in Compose and TweakScope while keeping edits, observation, and Reset under the application's control.

Summary

  • Reuse enum names and ordered options, decoding through the active source without reading inactive owners. The wire format and protocol version are unchanged.
  • Cover lazy reads, constant-specific enum bodies, invalid selections, owner updates, source replacement, shared ownership, and Reset.
  • Demonstrate app-owned enums with A/B animation state in the Compose sample and circle/square selection in the Views sample. Update the documentation.

Validation

  • All 220 Tweaks core and Compose unit tests pass.
  • Detekt and Android lint pass for both libraries and both samples.
  • Both samples build and pass lint with the real and no-op libraries.
  • Emulator QA: both samples return enum controls, accept tool edits, publish in-app changes, and reset correctly. The Compose overlay renders and selects A/B options; the Views preview renders the selected shape.
  • Strict MkDocs build and git diff --check pass.
  • Manual QA used the CLI and Android UI; the macOS tool pane was not exercised.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T15:39:36.160026Z b755dc8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rz-openai
rz-openai merged commit 415025c into main Oct 8, 2026
13 checks passed
@rz-openai
rz-openai deleted the codex/app-owned-enum-tweaks branch October 8, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant