Skip to content

Add persistent enable controls for saved ADB servers - #489

Merged
rz-openai merged 1 commit into
mainfrom
dev/rz/adb-server-controls
Oct 7, 2026
Merged

rz-openai merged 1 commit into
mainfrom
dev/rz/adb-server-controls

Conversation

@rz-openai

@rz-openai rz-openai commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Saved remote ADB servers reconnect automatically and must be removed to stop them. Add a persistent enable checkbox so users can disconnect a server without losing its settings.

Summary

  • Keep disabled servers saved, skip them during startup, and preserve their state when editing. Existing saved servers remain enabled.
  • Use compact rows with a leading checkbox, status dot or spinner, and device count. Move Edit/Delete into an overflow menu, support double-click to edit, and remove the footer.
  • Cover older saved profiles, disconnect/reconnect persistence, and progress during pending cleanup.

Validation

  • macOS app build and integration-test build passed with Xcode 26.4.1.
  • All 264 headless unit tests passed.
  • App runtime startup, shutdown, and termination-deadline harness passed.
  • Full SwiftFormat 0.61.1 and SwiftLint 0.63.2 checks passed.
  • GitHub CI passed on 5e36bdb7, including all macOS native suites, web checks, style checks, and the final CI gate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T22:16:36.336020Z 5e36bdb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rz-openai
rz-openai merged commit fa548fe into main Oct 7, 2026
8 checks passed
@rz-openai
rz-openai deleted the dev/rz/adb-server-controls branch October 7, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant