Skip to content

Add remote ADB servers and capability-based preview fallbacks - #488

Merged
rz-openai merged 7 commits into
mainfrom
dev/rz/video-startup-errors
Oct 7, 2026
Merged

rz-openai merged 7 commits into
mainfrom
dev/rz/video-startup-errors

Conversation

@rz-openai

@rz-openai rz-openai commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Devices without working surface video encoders or virtual touchscreens could hang on Connecting or receive slow input. Snap-O also lacked a way to discover and use devices through remote ADB servers. This adds capability-based fallbacks and saved SSH server connections while retaining the existing local ADB, MediaCodec, and uinput paths.

Summary

  • Report structured video startup failures, respect encoder limits, and fall back to ImageReader with compressed RGBA only for unsupported or permanently failing encoder startup.
  • Use ADB shell v2 for streaming and a persistent InputManager helper when uinput is unavailable; skip redundant clipboard writes at startup.
  • Connect to remote loopback ADB servers through private SSH Unix sockets, with independent discovery, reconnects, server-scoped device identity, and shutdown cleanup.
  • Add an ADB Servers window with saved, typed SSH profiles, add/edit/remove controls, and remote server labels in Device Manager. No device-specific detection or hardcoded server profiles.
  • Replace SSH subprocess test fixtures with fake-only shutdown unit tests and update the bundled helper contracts and release checks.

Validation

  • Passed 261 headless macOS unit tests across 49 suites, plus the fake-based tool-recovery suite. The Debug app build passed after both review fixes. Tests cover server removal and replacement, new subscribers, and remote legacy metadata. The earlier helper build and integration test-target build also passed.
  • SwiftFormat and strict SwiftLint passed.
  • Android normal and no-op assembly/lint, Detekt, public API checks, and bundled helper reproducibility with JDK 17 passed.
  • Host and both tool frontend formatting, lint, typecheck, and tests passed; both tool frontend builds passed.
  • Manual Waydroid preview and InputManager interaction were confirmed during development. The final SSH edit/shutdown fix still needs manual UI retesting.
  • Full app-launch/real-transport suites, Android test execution, and authoring validation remain for CI.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75832e9a3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app-macos/Snap-O/Device/ADB/ADBService.swift Outdated
Comment thread app-macos/Snap-O/Tools/ToolHTTPService.swift
Comment thread app-macos/AndroidHostService/ADBTunnelHost.swift
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T18:29:09.292428Z 154513c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rz-openai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 154513c9ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@rz-openai
rz-openai merged commit 1b12459 into main Oct 7, 2026
15 checks passed
@rz-openai
rz-openai deleted the dev/rz/video-startup-errors branch October 7, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant