fix: handle param.Opt types in ChatCompletionToolChoiceOptionUnionParam unmarshaling #527
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am unmarshaling This commit addresses issue openai#520 where the JSON unmarshaling fails for ChatCompletionToolChoiceOptionUnionParam when encountering OfAuto field with param.Opt[string] type. The decoder.field.Type.Elem() method was calling .Elem() on param.Opt[string] which is not a pointer type, causing unmarshaling to fail. Modified files and changes: - chatcompletion.go: * Added custom UnmarshalJSON method for ChatCompletionToolChoiceOptionUnionParam * Implemented proper handling of simple string values for OfAuto field * Added discriminated object unmarshaling based on "type" field * Added support for "function", "allowed_tools", and "custom" types * Replaced generic apijson.UnmarshalRoot call with type-specific handling This fix ensures that the union parameter can properly unmarshal both string values and complex objects without encountering type reflection errors when dealing with param.Opt types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #520 where the JSON unmarshaling fails for ChatCompletionToolChoiceOptionUnionParam
when encountering OfAuto field with param.Opt[string] type. The decoder.field.Type.Elem() method was calling
.Elem() on param.Opt[string] which is not a pointer type, causing unmarshaling to fail.
Modified files and changes:
This fix ensures that the union parameter can properly unmarshal both string values and complex objects
without encountering type reflection errors when dealing with param.Opt types.